-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose OnDeployExecutor Interface and store exception message on result node #1967
Expose OnDeployExecutor Interface and store exception message on result node #1967
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
Pull Request Test Coverage Report for Build 4748
💛 - Coveralls |
Will try to get to this next week. |
bundle/src/main/java/com/adobe/acs/commons/ondeploy/OnDeployExecutor.java
Show resolved
Hide resolved
bundle/src/main/java/com/adobe/acs/commons/ondeploy/impl/OnDeployExecutorImpl.java
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/adobe/acs/commons/ondeploy/impl/OnDeployExecutorImpl.java
Outdated
Show resolved
Hide resolved
Can you please help me understand the use case for |
@HitmanInWis I believe @geertsmichael discussed the use-case here: #1956 |
I'm not really seeing the use case, just the request to be able to call the OnDeployExecutor from other code. i.e. I see "what" is being requested (ability to re-trigger a script from code), but don't understand "why" it's being requested especially since the JMX console already allows re-running a script I believe AND a script can always be re-run by re-deploying the bundle (simply need to delete the status node if you are re-running a previously successful script). OnDeployScripts were always kinda meant to be one-time things, but I imagine folks have come up with other use cases that I'm not thinking of. Seeking to understand. |
The use-case is about a tool that I wrote, which will visualize the script execution (success, running, fail). This tool allows to do a re-run through my Touch UI tool. |
bundle/src/main/java/com/adobe/acs/commons/ondeploy/OnDeployExecutor.java
Show resolved
Hide resolved
One quick question remains about |
Everything tests out, merged. Thanks @michael-geerts for the contribution and @shsteimer for the recommended approach. |
Expose OnDeployExecutor Interface: so scripts can be triggered externally
Store exception message on result node: so it can be read