Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose OnDeployExecutor Interface and store exception message on result node #1967

Merged
merged 11 commits into from
Jun 29, 2019

Conversation

geertsmichael
Copy link
Contributor

Expose OnDeployExecutor Interface: so scripts can be triggered externally
Store exception message on result node: so it can be read

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented Jun 20, 2019

Pull Request Test Coverage Report for Build 4748

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 53.699%

Totals Coverage Status
Change from base Build 4744: 0.007%
Covered Lines: 13929
Relevant Lines: 25939

💛 - Coveralls

@HitmanInWis
Copy link
Contributor

Will try to get to this next week.

bundle/pom.xml Outdated Show resolved Hide resolved
content/pom.xml Outdated Show resolved Hide resolved
@HitmanInWis
Copy link
Contributor

Can you please help me understand the use case for Expose OnDeployExecutor Interface: so scripts can be triggered externally?

@davidjgonzalez
Copy link
Contributor

@HitmanInWis I believe @geertsmichael discussed the use-case here: #1956

@HitmanInWis
Copy link
Contributor

I'm not really seeing the use case, just the request to be able to call the OnDeployExecutor from other code. i.e. I see "what" is being requested (ability to re-trigger a script from code), but don't understand "why" it's being requested especially since the JMX console already allows re-running a script I believe AND a script can always be re-run by re-deploying the bundle (simply need to delete the status node if you are re-running a previously successful script).

OnDeployScripts were always kinda meant to be one-time things, but I imagine folks have come up with other use cases that I'm not thinking of. Seeking to understand.

@geertsmichael
Copy link
Contributor Author

The use-case is about a tool that I wrote, which will visualize the script execution (success, running, fail). This tool allows to do a re-run through my Touch UI tool.

@HitmanInWis
Copy link
Contributor

One quick question remains about CHANGELOG.md - other than that this looks good and I'll test it out later today.

@HitmanInWis HitmanInWis merged commit 595507a into Adobe-Consulting-Services:master Jun 29, 2019
@HitmanInWis
Copy link
Contributor

Everything tests out, merged. Thanks @michael-geerts for the contribution and @shsteimer for the recommended approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants