-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aem remote assets #1707
Feature/aem remote assets #1707
Conversation
…complete but proves out the pattern and includes the main pieces necessary for the feature
…rs (such as for DAM Update Assets) can choose to ignore events from, so that we can work w/assets without triggering unnecessary workflows.
… resource resolver
… performed by service users
… the admin user runs subsystems like resource property observation which can then trigger unexpected binary syncs
…zed but are okay for now.
…LUTIONS/acs-aem-commons into feature/aem-remote-assets # Conflicts: # bundle/src/main/java/com/adobe/acs/commons/remoteassets/impl/RemoteAssetsConfigImpl.java # bundle/src/main/java/com/adobe/acs/commons/remoteassets/impl/RemoteAssetsNodeSyncImpl.java
…LUTIONS/acs-aem-commons into feature/aem-remote-assets # Conflicts: # bundle/src/main/java/com/adobe/acs/commons/remoteassets/impl/RemoteAssetsConfigImpl.java # bundle/src/main/java/com/adobe/acs/commons/remoteassets/impl/RemoteAssetsNodeSyncImpl.java
…th performance slightly.
…sting binaries and different temporary assets.
…feature/aem-remote-assets
…orrectly convert Double props that come over in JSON as strings.
…onfig component, refactoring.
…hitelisted service users
Updated remote asset sync of date properties to maintain timezone
…cleaner logging, handle jpg/jpeg, closed streams.
…able session saving/refreshing.
…, only create binaries if the lastModified has changed.
@davidjgonzalez why is this being closed versus left open with the "Do NOT merge until 4.0.0 release" label like the other currently active PRs? |
@davidjgonzalez Now that 4.0.0 is released, can this be reopened? |
@badvision @davidjgonzalez FWIW I was trying to get this completed in time for Summit this year, as I know people will ask me about it. One very large company even reached out to me with their team of engineers looking for this feature. Even if 4.1.0 wont be officially released by Summit, it would be great if I could point people to ACS Commons and indicate it will be in the next release. |
…rviceUser to avoid creating an /etc/tags folder in AEM 6.4 or a /content/cq:tags folder in AEM 6.3
I think this was closed only because we had a lot of small fires to put out. Do we have a pr in the docs project to explain this one? I think the dev/QA use cases were rather compelling! |
Sounds good @badvision, thanks. I'm going to get onto the documentation task next - finally had time to sort out a couple final issues on this PR. Will link to it when ready, hopefully in the next day or two. |
The single remaining codeclimate issue I dont know a good way to resolve without making the code more obscure - to me its most clear the way it is, but happy to consider refactoring. I plan to have the documentation PR up this afternoon or sometime tomorrow. Just waiting on creative team to create a thumbnail for the feature :) |
And yay...if this gets merged I get to lay claim to bringing ACS Commons code coverage over 50% 😛 |
Documentation PR complete! |
@HitmanInWis -- any chance you can check into that switch statement complaint from Code Climate? |
@badvision The single remaining codeclimate issue I dont know a good way to resolve without making the code more obscure - to me its most clear the way it is, but if you insist it must be addressed I can take another look. |
…e-assets # Conflicts: # CHANGELOG.md
For example, I could put a bunch of callback functions (or objects with a function) into a map, fetch them from the map by key, and then call the function, but I'm not sure how much more "clear" that makes the code. In some ways it could be considered more obscure that way. |
I'm okay with adding a comment to disable that check for that one method. ;) |
…older(), as refactoring will likely not make the code any more straightforward.
Alright. Here we go! 😄 |
weeeee, thanks @badvision ! It's been a long time coming, just in time for Summit :) |
This is reopen of #1294 - the PR was previously approved, but was lacking junit tests and thus went stale and never got merged.
As a reminder, this is a PR for the "AEM Remote Assets" feature presented at 2018 Adobe Summit AEM Rockstar.
PR now has strong junit code coverage, and has been tested to work on AEM 6.3 and 6.4.
There are multiple use cases for this feature.
We currently have a client requesting this to be installed on their DEV servers to keep assets in sync w/o pulling the entire DAM, so we're looking forward to getting this officially merged and potentially enhanced further. I've also had other companies reach out to me directly regarding this feature.
One change I am considering is renaming this feature to be more accurate to what it is. Though the Summit Rock Star feature was termed "Remote Assets", perhaps this would better be termed "Asset Auto-Sync" or something along those lines. That way if AEM were to ever support assets from a truly remote DAM to be used directly it would avoid confusion.