Feature/httpcache request cookie extension #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
Pull Request Test Coverage Report for Build 3668
💛 - Coveralls |
added 4 commits
January 13, 2019 16:52
… this pattern will support key / value pairs based on more things such as request parameters, request headersvalue map values and more.
|
I made the approach more generic and extensible, so I can add a key/value key based on request headers, request parameters, value map values on the resource. Tested this locally and works fine. |
added 2 commits
January 14, 2019 12:41
justinedelson
pushed a commit
that referenced
this pull request
Feb 6, 2019
* Fixed a bug regarding the cacheKeyFactory target * RequestCookieExtension / key factory for HTTP cache * Modified the request cookie http cache extension to be more generic - this pattern will support key / value pairs based on more things such as request parameters, request headersvalue map values and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http cache config extension based on request cookie keys and values.
Allows you to create keys based on a cookie value. Useful for instance in the following scenario which is common:
Login to a middleware (AEM or otherwise) from the front-end
Login provides the user with a user type or group and saves this to the cookies.
Now we want to see different content (for example on a header menu list of links).
Here we can leverage the cookie value to show different content and cache it.