Feature/injector extensions - part 2 - last #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
December 27, 2018 11:02
Reflection utility class
…t manner. Also easy to use for dependency inversion with unit tests.
Supports resource and request adaptables.
Allows you to inject Json objects using GSON directly into your sling model. Will use the underlying resource valuemap to retrieve the JSON as property and parse it to the declared field type. Supports single values or list, set, collection.
…ructure (inheritance value map) to retrieve an inherited page property to inject it into your sling model. Supports request or resource.
# Conflicts: # CHANGELOG.md # bundle/src/main/java/com/adobe/acs/commons/i18n/impl/Config.java # bundle/src/main/java/com/adobe/acs/commons/i18n/impl/I18nProviderImpl.java # bundle/src/main/java/com/adobe/acs/commons/models/injectors/impl/AemObjectInjector.java # bundle/src/main/java/com/adobe/acs/commons/models/injectors/impl/HierarchicalPagePropertyInjector.java # bundle/src/main/java/com/adobe/acs/commons/models/injectors/impl/I18nInjector.java # bundle/src/main/java/com/adobe/acs/commons/util/impl/ValueMapTypeConverter.java # bundle/src/test/java/com/adobe/acs/commons/i18n/impl/I18nProviderImplTest.java # bundle/src/test/java/com/adobe/acs/commons/models/injectors/impl/AemObjectInjectorTest.java # bundle/src/test/java/com/adobe/acs/commons/models/injectors/impl/I18NInjectorTest.java # bundle/src/test/java/com/adobe/acs/commons/models/injectors/impl/model/TestModelI18nValue.java # bundle/src/test/java/com/adobe/acs/commons/models/injectors/impl/model/impl/TestJsonObject.java # bundle/src/test/java/com/adobe/acs/commons/models/injectors/impl/model/impl/TestJsonObjectInjectionImpl.java # bundle/src/test/java/com/adobe/acs/commons/models/injectors/impl/model/impl/TestModelI18nValueImpl.java
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
Pull Request Test Coverage Report for Build 3640
💛 - Coveralls |
justinedelson
pushed a commit
that referenced
this pull request
Feb 6, 2019
* Utility class for injectors - Reflection utility class * I18n Provider : Added a service to provide I18n values in a convenient manner. Also easy to use for dependency inversion with unit tests. * Added a json file to mock the aem context for injectors * Added aem context for injectors * I18n injector : Injects I18n values into your sling model. Supports resource and request adaptables. * Added a JSON injector: Allows you to inject Json objects using GSON directly into your sling model. Will use the underlying resource valuemap to retrieve the JSON as property and parse it to the declared field type. Supports single values or list, set, collection. * Hierarchical page property injector: traverses upwards in the page structure (inheritance value map) to retrieve an inherited page property to inject it into your sling model. Supports request or resource. * Cleaned up the AEMObject injector to remove code duplication. * Cleaned up the shared value map injector to remove redundant code. * Added copyright scripts * Added guava cache (count based) for the i18nprovider with JMX interface * Removed JsonInjector - this was renamed to JsonValueMapInjector. Fault in branching. * Removed unused I18n reference from AemObjectInjector. Moved to I18nInjector. * Remove unused I18nProvider from AemObjectInjector * Removed jsonannotationprocessorfactory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the last changes I had + corrected a mistake that I should have spotted in previous PR (renamed injector didn't got deleted)