Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to oakpal-1.1.13 for more maintainable unit tests. #1650

Merged
merged 7 commits into from
Jan 4, 2019
Merged

Upgrade to oakpal-1.1.13 for more maintainable unit tests. #1650

merged 7 commits into from
Jan 4, 2019

Conversation

adamcin
Copy link
Contributor

@adamcin adamcin commented Dec 21, 2018 •
edited
Loading

This PR incorporates the changes I made to improve the ProgressCheckFactory API in oakpal core.

  • Added a DSL for concise construction of org.json.JSONObject instances to improve maintainability of the tests for ProgressCheckFactories.
  • Refactored an emerging boilerplate pattern for evaluating lists of Rules.
  • Made all ProgressCheckFactories final and restricted visibility of their Check classes to package private.

BONUS: threw in 100% test coverage for XMLParserGeneratorFactory, which I picked at random to make up for elided SLOCs related to this module.

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 3597

  • 54 of 54 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 43.821%
Totals Coverage Status
Change from base Build 3563: 0.006%
Covered Lines: 10070
Relevant Lines: 22980
💛 - Coveralls

@adamcin adamcin force-pushed the feature/upgrade-to-oakpal-1_1_13 branch from 7ce8f76 to 144227f Compare January 3, 2019 19:51
@adamcin
Copy link
Contributor Author

adamcin commented Jan 4, 2019

@badvision this PR is ready for review.

@badvision badvision merged commit 1af52f2 into Adobe-Consulting-Services:master Jan 4, 2019
@badvision
Copy link
Contributor

Awesome. Thanks for your commitment to improving this! 😄

@badvision badvision added this to the 4.0.0 milestone Jan 4, 2019
davidjgonzalez pushed a commit to davidjgonzalez/acs-aem-commons that referenced this pull request Jan 27, 2019
@adamcin @davidjgonzalez
#merge - Upgrade to oakpal-1.1.13 for more maintainable unit tests. (A…
9f4c9b9 
…dobe-Consulting-Services#1650)
justinedelson pushed a commit that referenced this pull request Feb 6, 2019
@adamcin @justinedelson
Upgrade to oakpal-1.1.13 for more maintainable unit tests. (#1650)
d87bef3 
* Upgrade to oakpal-1.1.13 for more maintainable unit tests.

* Improvements to code coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adamcin @coveralls @badvision