Potential fix for Health Check Status Emailer Test failures #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does change the behavior slightly of the Health Check Status Emailer. It now sends the email if the threshold has been reached exactly (whereas before it would happen only if it was at least 1 millisecond after the threshold time). My theory is that this is failing on very fast machines. I've never seen this fail locally, but I guess that just means I need a new computer.
|
Thanks! This one was a bit of a pest. Can we run the travis build a few times to confirm this one? |
|
for sure |
|
I've restarted it 3 times and it seems fine. Thanks!! 👍 |
|
+1 from me... @davidjgonzalez ? |
davidjgonzalez
pushed a commit
to davidjgonzalez/acs-aem-commons
that referenced
this pull request
Jan 27, 2019
…nsulting-Services#1623) * Potential fix for Health Check Status Emailer Test failures This does change the behavior slightly of the Health Check Status Emailer. It now sends the email if the threshold has been reached exactly (whereas before it would happen only if it was at least 1 millisecond after the threshold time). My theory is that this is failing on very fast machines. I've never seen this fail locally, but I guess that just means I need a new computer. * updating changelog
justinedelson
added a commit
that referenced
this pull request
Feb 6, 2019
* Potential fix for Health Check Status Emailer Test failures This does change the behavior slightly of the Health Check Status Emailer. It now sends the email if the threshold has been reached exactly (whereas before it would happen only if it was at least 1 millisecond after the threshold time). My theory is that this is failing on very fast machines. I've never seen this fail locally, but I guess that just means I need a new computer. * updating changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does change the behavior slightly of the Health Check Status Emailer. It now sends the email if the threshold has been reached exactly (whereas before it would happen only if it was at least 1 millisecond after the threshold time). My theory is that this is failing on very fast machines. I've never seen this fail locally, but I guess that just means I need a new computer.