Retries count and retry pause is configurable for all Asset Ingestors #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
|
I'm not sure that having the timeout replaced with retry_pause is a good idea. timeout is more of a connection timeout interval and that could be several seconds. Retry pause in the FAM actions class is something that is usually in milliseconds. |
badvision
requested changes
Dec 14, 2018
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/processes/asset/FileAssetIngestor.java
Outdated
Show resolved
Hide resolved
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/processes/asset/UrlAssetImport.java
Outdated
Show resolved
Hide resolved
|
Hi @badvision, |
badvision
approved these changes
Dec 14, 2018
davidjgonzalez
pushed a commit
to davidjgonzalez/acs-aem-commons
that referenced
this pull request
Jan 27, 2019
…Adobe-Consulting-Services#1612) * Retries count and retry pause is configurable for all Asset Ingestors
justinedelson
pushed a commit
that referenced
this pull request
Feb 6, 2019
…#1612) * Retries count and retry pause is configurable for all Asset Ingestors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new configuration field was added for FAM tasks:
-retry count
-retry pause