Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial implementation of an S3 ingestor for MCP #1133

Merged
merged 19 commits into from
Oct 10, 2017

Conversation

justinedelson
Copy link
Contributor

@justinedelson justinedelson commented Oct 3, 2017

includes some internal refactoring to avoid code duplication between S3 and File ingestor, although some still exists

includes some internal refactoring to avoid code duplication between S3 and File ingestor, although some still exists
@justinedelson
Copy link
Contributor Author

Here's the problem with the StringUtils class... S3 Mock depends upon a method added in the 1.10.77 release of the AWS SDK. Naturally, AEM uses 1.10.76. So with just the AEM version on the classpath, S3 Mock fails miserably. So I took the latest copy of the StringUtils class and incorporated in into the codebase (as a test file) so that it would get picked up at test time. Would it have been better if S3 Mock used Commons StringUtils? sure. But I don't think that's likely to change.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.4%) to 29.756% when pulling e308f97 on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 3, 2017

Coverage Status

Coverage increased (+0.4%) to 29.775% when pulling 4073a97 on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 4, 2017

Coverage Status

Coverage increased (+0.4%) to 29.775% when pulling 68a0479 on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage increased (+0.5%) to 29.895% when pulling ec43976 on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage increased (+0.5%) to 29.89% when pulling b642a57 on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage increased (+0.6%) to 29.979% when pulling 9fb2f2d on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 5, 2017

Coverage Status

Coverage increased (+0.8%) to 30.16% when pulling 5897f76 on feature/s3-asset-ingestor into 5e1694e on master.

@justinedelson
Copy link
Contributor Author

@badvision @davidjgonzalez I think this is now ready to merge.

Copy link
Contributor

@badvision badvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@coveralls
Copy link

coveralls commented Oct 6, 2017

Coverage Status

Coverage increased (+0.8%) to 30.16% when pulling 714e18a on feature/s3-asset-ingestor into 5e1694e on master.

@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage increased (+0.8%) to 30.159% when pulling 70bb46d on feature/s3-asset-ingestor into 5e1694e on master.

@justinedelson justinedelson added this to the 3.11.0 milestone Oct 10, 2017
@justinedelson justinedelson merged commit 181257c into master Oct 10, 2017
YegorKozlov pushed a commit to YegorKozlov/acs-aem-commons that referenced this pull request Oct 12, 2017
@davidjgonzalez davidjgonzalez deleted the feature/s3-asset-ingestor branch January 24, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants