-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation of an S3 ingestor for MCP #1133
Conversation
includes some internal refactoring to avoid code duplication between S3 and File ingestor, although some still exists
Here's the problem with the StringUtils class... S3 Mock depends upon a method added in the 1.10.77 release of the AWS SDK. Naturally, AEM uses 1.10.76. So with just the AEM version on the classpath, S3 Mock fails miserably. So I took the latest copy of the StringUtils class and incorporated in into the codebase (as a test file) so that it would get picked up at test time. Would it have been better if S3 Mock used Commons StringUtils? sure. But I don't think that's likely to change. |
@badvision @davidjgonzalez I think this is now ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
…prefix'd item when they shouldn't
includes some internal refactoring to avoid code duplication between S3 and File ingestor, although some still exists