Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui.content package should specify ui.apps dependency as <type>zip</type> not <type>content-package</type> #3115

Closed
3 tasks done
adamcin opened this issue May 30, 2023 · 0 comments

Comments

@adamcin
Copy link
Contributor

adamcin commented May 30, 2023

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: N/A
  • ACS AEM Commons Version: 6.0.8
  • Reproducible on Latest? YES

Expected Behavior

Successful resolution of direct dependencies.

It would also be advisable to add <scope>provided</scope> to the embedded package dependencies within the acs-aem-commons-all pom.xml.

Actual Behavior

Transitive dependency resolution for the following dependency fails to resolve ui.apps-6.0.8.content-package from maven central.

<dependency>
      <groupId>com.adobe.acs</groupId>
      <artifactId>acs-aem-commons-all</artifactId>
      <version>6.0.8</version>
      <type>zip</type>
</dependency>

The maven build output is as follows:

07:18:19,344 [main] [ERROR] Error downloading dependencies for project
07:18:19,344 [main] [ERROR] Failure to find com.adobe.acs:acs-aem-commons-ui.apps:content-package:6.0.8 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced
07:18:19,366 [main] [WARNING] Failure to find com.adobe.acs:acs-aem-commons-ui.apps:content-package:6.0.8 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced

The log indicates that the incorrect <type>content-package</type> is defined here:

<type>content-package</type>

Steps to Reproduce

This is only an issue when a project that does not add filevault-package-maven-plugin with <extensions>true</extensions>, adds a dependency that transitively includes com.adobe.acs:acs-aem-commons-ui.content, where this dependency type is defined.

adamcin added a commit to adamcin/acs-aem-commons that referenced this issue May 30, 2023
…n ui.content/pom.xml from content-package to zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant