Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DesignReferenceProvider provides reference for the design resource which doesn't have content resource #3066

Closed
3 tasks
pankaj-parashar opened this issue Mar 14, 2023 · 0 comments
Labels
Milestone

Comments

@pankaj-parashar
Copy link
Contributor

As per api doc https://developer.adobe.com/experience-manager/reference-materials/6-5/javadoc/com/day/cq/wcm/api/designer/Design.html#getContentResource-- , the api can return null if the design doesn't have the content resource. In this case, DesignReferenceProvider still returning reference which will return null for the api https://developer.adobe.com/experience-manager/reference-materials/6-5/javadoc/com/day/cq/wcm/api/reference/Reference.html#getResource-- this can cause NPE in the code consuming the references provided by DesignReferenceProvider. It shouldn't references for the valid resource only.

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: _______
  • ACS AEM Commons Version: _____
  • Reproducible on Latest? yes/no

Expected Behavior

Please describe briefly the expected behavior, i.e. when I do X, Y should happen.

Actual Behavior

Please describe briefly the actual behavior, i.e. when I do X, Z happens.

Steps to Reproduce

Starting from a vanilla instance of AEM at the above version, describe in explicit steps how to reproduce. Link to
any supporting assets, e.g. content packages, below

Links

Links to related assets, e.g. content packages containing test components

@pankaj-parashar pankaj-parashar changed the title DesignReferenceProvider provides reference for the design resource which doesn't has content DesignReferenceProvider provides reference for the design resource which doesn't have content resource Mar 14, 2023
pankaj-parashar added a commit to pankaj-parashar/acs-aem-commons that referenced this issue Mar 14, 2023
… reference for the design resource which doesn't have content resource
davidjgonzalez pushed a commit that referenced this issue Mar 20, 2023
… resource which doesn't have content resource (#3067)
@davidjgonzalez davidjgonzalez added this to the 6.0.4 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants