Shared Component Properties do not work in AEM 6.5

[reggie7]

• AEM Version: 6.5
• ACS AEM Commons Version: 4.0.0
• Reproducible on Latest? yes

Expected Behavior

Shared Component Properties works properly in AEM 6.5.

Actual Behavior

Shared Component Properties does not work properly in AEM 6.5:

• Shared Properties dialog does not open at all.
• Global Properties dialog does not open at all.
• Configure dialog does not open after clicking an icon for one of the above mentioned dialogs.

Steps to Reproduce

1. Follow How to use steps,
2. Remember that com.adobe.acs.commons.wcm.impl.PageRootProviderImpl is actually wrong - use com.adobe.acs.commons.wcm.impl.PageRootProviderConfig instead,
3. Create an example page for yourself where you'd get something like this:

4. Click the first icon - it should work,
5. Click the second icon - it does not work,
6. Click the third icon - it does not work,
7. Click the first icon again - it does not work anymore.

[davidjgonzalez]

@HitmanInWis have you had a chance to try SCP's out in AEM 6.5 yet?

+1 on the documentation update though..

[HitmanInWis]

I've not yet tested SCP on AEM 6.5. I'll see if I can take a look this week to at least gauge the effort to fix. And yes, I should also get that documentation of PageRootProviderConfig updated...

[reggie7]

@HitmanInWis - please note this PR though, it should be enough for the docs maybe?

[HitmanInWis]

Thank you @reggie7 for banging out that documentation update! That is merged now.

[HitmanInWis]

I just tested Shared Component Properties (SCP) out on AEM 6.5 and it's working just fine for me. It's possible that the problem is only with the example package, since that was created quite possibly on AEM 6.1...

[HitmanInWis]

Found the issue, and turns out the effect is largely just the example package. However, if someone implemented SCP by copying code from the example package then I guess it would affect them as well.

Back in AEM 6.1 a workaround was needed where SCP dialogs needed to use a special "acs-commons/gui/components/authoring/dialogshared" type to prevent a NPE for the dialog when the node storing the content did not yet exist, but this has not been necessary since AEM 6.2. I think because SCP officially went live in ACS Commons when 6.2 was the main AEM version we never even included this in documentation. Dialogs using the OOTB sling:resourceType of cq/gui/components/authoring/dialog work just fine.

Apparently on AEM 6.5 the custom resource type in ACS Commons is no longer working. Ideally we'd just delete this old resource type from ACS Commons as it is absolutely not necessary and truly should be avoided to prevent future compatibility issues. However, given the chance that someone might be using that old ACS Commons resourceType (even with it not being officially documented) I'm wondering if we instead need to update that resourceType to work on 6.5 (probably just remove all of the custom code and have it descend from the default type).

[HitmanInWis]

Fixed the issue for sake of backward compatibility (see above PR).

[reggie7]

Just checked it and it indeed works with the new example package. Thank you, @HitmanInWis

[nafeespeer]

Hi @reggie7 and @HitmanInWis - Could you please provide me the latest documentation to make this feature work in AEM 6.5?

I am not able to find those nodes mentioned in the documentation in AEM 6.5 for "Adding the Page Info Provider to your Page Component". Any help here would be appreciated?

[HitmanInWis]

you need to find your base page component - it might not already have a cq:infoProviders node and if it doesnt then you'll have to add one. If you find the base page component under /libs in AEM you can see the default version of the cq:infoProviders node.