Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder creator - cannot create numeric folder #1791

Closed
aaantoine opened this issue Mar 18, 2019 · 1 comment
Closed

folder creator - cannot create numeric folder #1791

aaantoine opened this issue Mar 18, 2019 · 1 comment
Assignees

Comments

@aaantoine
Copy link

Required Information

  • [ 6.4.3] AEM Version, including Service Packs, Cumulative Fix Packs, etc: _______
  • [3.19.0 ] ACS AEM Commons Version: _____
  • [yes] Reproducible on Latest? yes/no

Expected Behavior

I provide a excel file with some folders alphanumeric ( for example : 2018), I expect that the folder 2018 is created

Actual Behavior

The folder is not created and an exception is raised :

2019-03-18 15:04:22   Cannot get a STRING value from a NUMERIC cell java.lang.IllegalStateException: Cannot get a STRING value from a NUMERIC cell at org.apache.poi.xssf.usermodel.XSSFCell.typeMismatch(XSSFCell.java:1062) at org.apache.poi.xssf.usermodel.XSSFCell.getRichStringCellValue(XSSFCell.java:395) at org.apache.poi.xssf.usermodel.XSSFCell.getStringCellValue(XSSFCell.java:347) at com.adobe.acs.commons.mcp.impl.processes.AssetFolderCreator.parseAssetFolderCell(AssetFolderCreator.java:188) at com.adobe.acs.commons.mcp.impl.processes.AssetFolderCreator.parseAssetFolderRow(AssetFolderCreator.java:170) at com.adobe.acs.commons.mcp.impl.processes.AssetFolderCreator.lambda$parseAssetFolderDefinitions$0(AssetFolderCreator.java:151) at com.adobe.acs.commons.fam.impl.ActionManagerImpl.withResolver(ActionManagerImpl.java:214) at com.adobe.acs.commons.mcp.impl.processes.AssetFolderCreator.parseAssetFolderDefinitions(AssetFolderCreator.java:142) at com.adobe.acs.commons.mcp.impl.ProcessInstanceImpl.lambda$runStep$14(ProcessInstanceImpl.java:235) at com.adobe.acs.commons.fam.impl.ActionManagerImpl.withResolver(ActionManagerImpl.java:214) at com.adobe.acs.commons.fam.impl.ActionManagerImpl.runActionAndLogErrors(ActionManagerImpl.java:176) at com.adobe.acs.commons.fam.impl.ActionManagerImpl.lambda$deferredWithResolver$0(ActionManagerImpl.java:168) at com.adobe.acs.commons.fam.impl.TimedRunnable.run(TimedRunnable.java:88) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)

Steps to Reproduce

Upload an excel file with the value 2018 in a row, and launch the folder creator with this excel file, Lowercase With Dashes as primary creator
Starting from a vanilla instance of AEM at the above version, describe in explicit steps how to reproduce. Link to
any supporting assets, e.g. content packages, below

Links

Links to related assets, e.g. content packages containing test components

davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Mar 18, 2019
@davidjgonzalez
Copy link
Contributor

Thanks @aaantoine - should be fixed in: #1792

@davidjgonzalez davidjgonzalez added this to the 4.0.2 milestone Mar 18, 2019
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Mar 18, 2019
@davidjgonzalez davidjgonzalez self-assigned this Mar 18, 2019
badvision pushed a commit that referenced this issue Mar 25, 2019
#1792)

* #1791 - Asset Folder Creator to support non-string cell types (ie. Numeric)
@justinedelson justinedelson modified the milestones: 4.0.2, 4.1.2 May 7, 2019
@davidjgonzalez davidjgonzalez removed this from the 4.1.2 milestone Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants