Review use of QueryBuilder and prevent ResourceResolver leakage

[davidjgonzalez]

Use of QueryBuilder APIs for querying often results in a leaking ResourceResolver.

The ACS Commons code-base should be reviewed for use of QueryBuilder and any leakage should be mitigated.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[adamcin]

@davidjgonzalez I think we should reopen this issue after merging #1686 . The CloseableQueryBuilder should ease mitigation in most places.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[davidjgonzalez]

@adamcin Do you recall where this was left off? I thought you actually ended up going through and updated the uses of QueryBuilder to use CloseableQueryBuilder. Do you recall if you only tackled a subset?

[adamcin]

@davidjgonzalez I believe I converted all usages of QueryBuilder that were present at the time.

[davidjgonzalez]

thanks @adamcin took a quick scan and looks like you did; there were a few unused references left but easy enough to clean up in #1794 - thanks!!!

[davidjgonzalez]

This was fixed w/ CloseableQueryBuilder