update compatibiltiy for $method modifier #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxgunchenko
approved these changes
Jun 7, 2023
slavaleleka
reviewed
Jun 7, 2023
slavaleleka
requested changes
Jun 7, 2023
slavaleleka
requested changes
Jun 7, 2023
@slavaleleka what exact version should be specified? |
|
version of extension since which the modifier is supported, i.e. v4.1 does not support it yet |
what version will it be? |
|
I do not know what version it will be but it definitely should be specified. so the PR may be marked as WIP for now, isn't it? |
ameshkov
requested changes
Jun 9, 2023
|
|
||
| > **Compatibility with different versions of AdGuard** | ||
| > | ||
| > `$method` is available starting with CoreLibs v1.12. | ||
| > Rules with the `$method` are supported by AdGuard for Windows, Mac, Android, **running CoreLibs v1.12 or later**, and AdGuard Browser extension for Chrome, Firefox, Edge. |
There was a problem hiding this comment.
@ameshkov v4.2, but we were considering adding TSUrlFilter version here, in a similar fashion as CoreLibs
ameshkov
approved these changes
Jun 20, 2023
slavaleleka
reviewed
Jun 20, 2023
slavaleleka
approved these changes
Jun 20, 2023
sfionov
reviewed
Jun 20, 2023
|
|
||
| **Examples** | ||
|
|
||
| * `||evil.com^$method=get|head` blocks only GET and HEAD requests to `evil.com`. | ||
| * `||evil.com^$method=~post|~put` blocks any requests except POST or PUT to `evil.com`. | ||
| * `||evil.com^$method=~post|~put` blocks any requests to `evil.com`,except POST or PUT. |
There was a problem hiding this comment.
+ лишний после any requests
sxgunchenko
suggested changes
Jun 20, 2023
Co-authored-by: Slava <[email protected]>
Co-authored-by: Sergei Gunchenko <[email protected]>
sxgunchenko
approved these changes
Jun 20, 2023
sfionov
approved these changes
Jun 21, 2023
|
Merged as a part of #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.