Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve '!#safari_cb_affinity' directive — support 'advanced' value for Advanced Protection in AdGuard for iOS #226

Closed
Alex-302 opened this issue Aug 20, 2024 · 0 comments
Closed

Improve '!#safari_cb_affinity' directive — support 'advanced' value for Advanced Protection in AdGuard for iOS #226

Alex-302 opened this issue Aug 20, 2024 · 0 comments
Assignees
@slavaleleka
Labels
enhancement Improvement of existent feature Priority: P4 Resolution: Fixed Status: Closed

Comments

@Alex-302
Copy link
Member

Alex-302 commented Aug 20, 2024 •
edited by slavaleleka
Loading

Problem

Blocking of some ads requires applying both basic rule + advanced rule. The problem is that in free AdGuard for iOS only a basic rule can be applied, which breaks a site completely, because advanced rule is not applied.

Example:

||ads.com/loader.min.js$domain=example.com
example.com#%#//scriptlet('abort-on-stack-trace', 'document.getElementById', 'onerror')

Without the second rule, after applying only the first rule, the site will be broken.

Proposed solution

Add ability to apply a rule on iOS, only if advanced protection is enabled. The basic rule must be applied in specified content blocker(s).
@Alex-302 Alex-302 added the enhancement Improvement of existent feature label Aug 20, 2024
@Alex-302 Alex-302 mentioned this issue Aug 20, 2024
Closed
@adguard-bot adguard-bot changed the title Improve !#safari_cb_affinity - add ability to add a rule only for AdGuard for iOS with Advanced Protection Improve '!#safari_cb_affinity' directive — support 'advanced' value for Advanced Protection in AdGuard for iOS Aug 22, 2024
@slavaleleka slavaleleka mentioned this issue Aug 22, 2024
Draft
adguard pushed a commit that referenced this issue Aug 23, 2024
@slavaleleka
add more tests for safari_cb_affinity directive. #226 AG-35318
3b695a1 
Squashed commit of the following:

commit f3d2bc0
Author: Slava Leleka <[email protected]>
Date:   Thu Aug 22 00:26:27 2024 +0300

    fix linter

commit 0e0040b
Author: Slava Leleka <[email protected]>
Date:   Thu Aug 22 00:25:38 2024 +0300

    fix multiple tests

commit 723000e
Author: Slava Leleka <[email protected]>
Date:   Thu Aug 22 00:20:31 2024 +0300

    add more tests for safari_cb_affinity directive
adguard pushed a commit to AdguardTeam/VscodeAdblockSyntax that referenced this issue Aug 23, 2024
@slavaleleka
support advanced value for !#safari_cb_affinity. AG-35318
732a673 
AdguardTeam/FiltersCompiler#226

Squashed commit of the following:

commit ee1ed4c
Author: Slava Leleka <[email protected]>
Date:   Thu Aug 22 21:17:58 2024 +0300

    support advanced for safari_cb_affinity
@Alex-302 Alex-302 mentioned this issue Aug 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement Improvement of existent feature Priority: P4 Resolution: Fixed Status: Closed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Alex-302 @adguard-bot @slavaleleka