Adding support for ABP CSS injections

[monzta]

euronews.com###o-site-hr__leaderboard-wallpaper.u-show-for-xlarge {remove:true;} added in easylist/easylist@99c717f stated to throw errors: https://github.com/easylist/easylist/actions/runs/11801052352/job/32873439085

Seems it doesn't know ABP syntax of {remove:true;}.

[ameshkov]

Uh, can ABP consider using a different marker for these rules?

Here's the version compatible with AdGuard and uBO:
euronews.com#$##o-site-hr__leaderboard-wallpaper.u-show-for-xlarge {remove:true;}

[monzta]

Oh, #$# is already reserved for snippet filters. :/

[ameshkov]

Meh :(

I don't see it documented yet:
https://help.adblockplus.org/hc/en-us/articles/360062733293-How-to-write-filters

Is there any place where this syntax is described? If using #$# is not possible, we'll need to add conversion code to support it on AdGuard side.

@scripthunter7 could you please check this out and create tasks for this syntax support in tsurlfilter and CoreLibs?

[scripthunter7]

You can disable AGLint for that line temporarily: https://github.com/AdguardTeam/AGLint?tab=readme-ov-file#ignore-single-adblock-rule

[monzta]

Oh yeah, it's only mentioned here and it links to the page I linked.

@scripthunter7 Great, thanks!

[ameshkov]

@monzta no I meant the {remove:true} syntax, can't find it anywhere in the docs

[monzta]

@ameshkov oh, of course 🤦🏻‍♂️ This hasn't been added there yet. I'll take care of it.

[scripthunter7]

@ameshkov Opened issues in tsurlfilter and CL

[monzta]

fyi #?# filters like example.org#?#div:-abp-has(> div:-abp-properties(width: 44px)) {remove: true;} also work

[scripthunter7]

@monzta thank you, added to issues

[ameshkov]

@monzta it seems that it's not just remove: true?
https://www.abptestpages.org/en/abp-testcase-subscription.txt

I see this as well:

abptestpages.org##.testcase-inline-css-ehe {background-color: #c70d2c;}
abptestpages.org#@#.testcase-inline-css-ehe

[monzta]

@ameshkov You are right. Note that these currently only work for privileged filter lists in ABP.

[Yuki2718]

As mentioned in Slack, the syntax is documented in release notes
https://gitlab.com/eyeo/adblockplus/abc/webext-ad-filtering-solution/-/releases/1.3.0
https://gitlab.com/eyeo/adblockplus/abc/webext-ad-filtering-solution/-/releases/1.4.0

[Yuki2718]

You are right. Note that these currently only work for privileged filter lists in ABP.

Does that mean EL is now privileged? I thought only ABP filter is privileged in ABP.

[monzta]

No, ABP Filters only for CSS inline styles. remove works in any list.

[scripthunter7]

@monzta If you don't mind, I think this issue could be renamed to something like "Adding support for ABP CSS injections" as I understand it includes both CSS injection and remove

[monzta]

@scripthunter7 Sure, done.