-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend assertNotExist with a new implementation using a viewMatcher as a param #479
Conversation
By the way, checking the current readme we have, if we start implementing things like this, we should also add the rest of matchers, right? I mean assertExists, assertVisible... etc... |
Hello @rocboronat , |
Also I run locally the step that failed with the CI: ./gradlew :sample:connectedCheck :barista-compose:connectedCheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @moutyque! Sorry for the delay on my review. I was out of laptop for holidays.
Thanks for this PR. I think it could be very useful!
Btw, as I agree with @rocboronat on other methods, I will suggest to create at least the assertExists
variant also, so we have both positive and negative versions. Later another PR for other kind of methods.
What do you think?
Hello @alorma , |
@alorma can you check again. |
No description provided.