Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code style script #472

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Fix code style script #472

merged 1 commit into from
Dec 3, 2022

Conversation

Sloy
Copy link
Member

@Sloy Sloy commented Dec 2, 2022

@Sloy Sloy requested a review from alorma December 2, 2022 16:42
@rocboronat
Copy link
Member

Yey, I would say yes to the first comment deletion, but the second one... well, with it you know there are .xml files there 😅

Do we really care about those comments? Or did they actually break the script?

@rocboronat
Copy link
Member

Oh, the ""!!!! Forget my comment.

@alorma alorma enabled auto-merge (squash) December 3, 2022 12:49
@alorma alorma merged commit ac8063e into master Dec 3, 2022
@alorma alorma deleted the fix-code-style branch December 3, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alorma alorma alorma approved these changes

@rocboronat rocboronat rocboronat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sloy @rocboronat @alorma