Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelise Github actions #417

Merged
merged 1 commit into from
May 27, 2021
Merged

Parallelise Github actions #417

merged 1 commit into from
May 27, 2021

Conversation

Sloy
Copy link
Member

@Sloy Sloy commented May 27, 2021

We have 2 actions, one for the build and another for running instrumentation tests.
Right now, the instrumentation action waits for the build to finish first. It takes about 2 minutes. But there's no need for that, really. There's no dependency between them or any reused output. So we could save 2 minutes by starting the instrumentation build as soon as possible.

Copy link
Member

@alorma alorma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad 😅😅

@Sloy Sloy enabled auto-merge (squash) May 27, 2021 12:39
@Sloy Sloy merged commit 5716b9b into master May 27, 2021
@Sloy Sloy deleted the parallel-actions branch May 27, 2021 12:44
@rocboronat
Copy link
Member

I guess that's because it was great to save some cpu cycles passing the instrumentation tests in case the unit tests don't pass. When we did it I guess we were limited to a number of daily instrumentation tests or something like that, like in the free tier of Firebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants