Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage collaborators to add tests written in Java #409

Merged
merged 3 commits into from
May 28, 2021
Merged

Conversation

rocboronat
Copy link
Member

This PR adds a subsection to the contributing section.

Copy link
Member

@Sloy Sloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Member

@alorma alorma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we wait until #412 is merged so instead of this section we can link the contributing guide directly?

@rocboronat
Copy link
Member Author

I wrote this thing first 😄 but yes, if everyone is ok with it, we could merge the other one, close this PR, and open a new one pointing to the contributions page in the readme. Everything is fine 😄

@Sloy
Copy link
Member

Sloy commented May 28, 2021

Fine by me!

@Sloy Sloy merged commit 910e95f into master May 28, 2021
@Sloy Sloy deleted the rocboronat-patch-3 branch May 28, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants