Add support to vector drawable using AppCompat #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafaberkaymutlu
approved these changes
May 4, 2021
Sloy
changed the title
|
Thank you so much, @laggedHero! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
We are using Barista and recently something caught our attention: some of our tests (API 23) where failing.
Turns out it was the way drawables are handled.
This project minSDK is 19, which means (by the way of official docs) that we need to use a back compat solution. Even when considering API 23, VectorDrawableCompat docs states that
For API 24 and above, this class delegates to the framework's VectorDrawable. For older API version, this class lets you create a drawable based on an XML vector graphic.- using a compat solution would still be needed.Let me know whatever is needed to get this in the right state.
Thank you.