-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BackgroundMatcher to compare GradientDrawables #384
Update BackgroundMatcher to compare GradientDrawables #384
Conversation
Thank you for the fix @sarn0ld! |
Hello @sarn0ld ! Thanks a lot for the PR! As Barista is becoming a project used by thousands, may you mind adding a test that reproduces the issue you describe? Thanks a lot again! :·) |
Hey @Sloy @rocboronat ! Please feel free to edit my changes if something is wrong or different than you'd expect it to be! |
Hi @sarn0ld We updated the library package, so now this PR has some conflicts that needs to be fixed before merge. We will solve the conflicts before merge. |
At the moment, when you use
assertHasBackground()
with a drawable like this:then an exception is thrown because the drawable height and width are zero.
Instead of using
DrawableToBitmapConverter
aShapeDrawable
(=GradientDrawable
) should be checked directly like aColorDrawable
.