Made public: #209
Closed
Made public: #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertDisplayed(viewMatcher: Matcher<View>) assertNotDisplayed(viewMatcher: Matcher<View>) assertNotExist(viewMatcher: Matcher<View>) clickOn(viewMatcher: Matcher<View>) scrollTo(matcher: Matcher<View>) safelyScrollTo(matcher: Matcher<View>) Added: assertEffectivelyVisible(viewMatcher: Matcher<View>)
Litemn
approved these changes
Mar 1, 2018
SergeyAlekseevN
approved these changes
Mar 1, 2018
|
Hi! Thanks for the contribution @gopito. In the case of the assert methods, do you think the new method added in #198 will be enough for your use case? It basically adds a public |
|
Hi @Sloy. |
|
I'm glad it helps you. I just triggered the release of v2.4.0 with the new change. It should be available in a few minutes. Thanks for reporting you case and contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of complex selectors. Lots of "allOf(...)" in our tests on java. So it will be very convenient to have additional public methods with matchers as argument.
Made public:
assertDisplayed(viewMatcher: Matcher)
assertNotDisplayed(viewMatcher: Matcher)
assertNotExist(viewMatcher: Matcher)
clickOn(viewMatcher: Matcher)
scrollTo(matcher: Matcher)
safelyScrollTo(matcher: Matcher)
Added:
assertEffectivelyVisible(viewMatcher: Matcher)