-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.4.1 #35
Merged
Merged
V1.4.1 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to skip methane init prompt and use default configurations.
…ndComponentDirectory function
…default file name if user-config generateFolder is set to true Added a conditional to check if the user config has the generate folder set to true, hence the page file name is set to index.jsx or index.tsx (depending on user config). This will make the import statements cleaner and only name the page if the generateFolder is set to false
… use index as default filename if generateFolder config is set
… as default filename if generateFolder config is set
…on to use index as default filename if generateFolder config is set
…rom stylesheet imports
…tylesheet imports
…e from stylesheet imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The patch version 1.4.1 aims to fix issues related to the components and pages generation.
index.jsx
orindex.tsx
if generateFolder configuration is specified. This makes components and pages import cleaner and easier to understand. For example, if you generate a component calledButton
, the generated component path would beButton/index.jsx
orButton/index.tsx
and you can import it like thisimport Button from './components/Button'
. Unlike before where you would have to import it like thisimport Button from './components/Button/Button'
.button
, the file name remainsbutton
but the generated component would bebutton
instead ofButton
. This has been fixed in this version.-d
or--default
tomethane init
command. This allows developers to easily initialize Methane with the default configuration without being prompted to answer questions. This is useful when you want to quickly initialize Methane in a new project. Note You can always update the Methane configuration by runningmethane config
command.