Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sklearn change causes error ('super' object has no attribute '__sklearn_tags__') in test suite #204

Closed
2 tasks done
stes opened this issue Dec 16, 2024 · 0 comments · Fixed by #205
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@stes
Copy link
Member

stes commented Dec 16, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Bug description

The current test suite yields the following error

____________________ ERROR collecting tests/test_sklearn.py ____________________
tests/test_sklearn.py:2[56](https://github.com/AdaptiveMotorControlLab/CEBRA/actions/runs/12357735292/job/34486685645?pr=190#step:10:57): in <module>
    @_util.parametrize_with_checks_slow(
tests/_util.py:66: in parametrize_with_checks_slow
    fast_params = [
tests/_util.py:67: in <listcomp>
    list(
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/sklearn/utils/estimator_checks.py:543: in estimator_checks_generator
    for check in _yield_all_checks(estimator, legacy=legacy):
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/sklearn/utils/estimator_checks.py:3[59](https://github.com/AdaptiveMotorControlLab/CEBRA/actions/runs/12357735292/job/34486685645?pr=190#step:10:60): in _yield_all_checks
    tags = get_tags(estimator)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/sklearn/utils/_tags.py:405: in get_tags
    sklearn_tags_provider[klass] = klass.__sklearn_tags__(estimator)  # type: ignore[attr-defined]
/opt/hostedtoolcache/Python/3.9.20/x[64](https://github.com/AdaptiveMotorControlLab/CEBRA/actions/runs/12357735292/job/34486685645?pr=190#step:10:65)/lib/python3.9/site-packages/sklearn/base.py:859: in __sklearn_tags__
    tags = super().__sklearn_tags__()
E   AttributeError: 'super' object has no attribute '__sklearn_tags__'

Operating System

github actions

CEBRA version

latest main

Device type

cpu

Steps To Reproduce

No response

Relevant log output

No response

Anything else?

This issue seems related to the following change in the sklearn API: scikit-learn/scikit-learn#29677

Code of Conduct

@stes stes added the bug Something isn't working label Dec 16, 2024
@stes stes self-assigned this Dec 16, 2024
@stes stes closed this as completed in #205 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant