Merge pull request #18 from AdamSpannbauer/damping_fix

Damping fix
AdamSpannbauer · Dec 4, 2018 · b593122 · b593122
2 parents 9518877 + 3815546
commit b593122
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: lexRankr
 Type: Package
 Title: Extractive Summarization of Text with the LexRank Algorithm
-Version: 0.5.1
+Version: 0.5.2
 Author: Adam Spannbauer [aut, cre], Bryan White [ctb]
 Maintainer: Adam Spannbauer <[email protected]>
 Description: An R implementation of the LexRank algorithm described by G. Erkan and D. R. Radev (2004) <DOI:10.1613/jair.1523>.

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,8 @@
 
+# lexRankr 0.5.2
+
+* fix damping bug where damping parameter wasn't passed to  `igraph::pagerank`
+
 # lexRankr 0.5.1
 
 * changed `smart_stopwords` to be internal data so that package doesnt need to be explicitly loaded with `library` to be able to parse

diff --git a/R/lexRankFromSimil.R b/R/lexRankFromSimil.R
@@ -51,7 +51,7 @@ lexRankFromSimil <- function(s1, s2, simil, threshold=.2, n=3, returnTies=TRUE,
     if(length(damping) != 1) stop("damping must be length 1")
 
     sentGraph <- igraph::graph_from_data_frame(edges, directed = FALSE)
-    sentRank <- igraph::page_rank(sentGraph, directed=FALSE)$vector
+    sentRank <- igraph::page_rank(sentGraph, directed=FALSE, damping=damping)$vector
     sentRanksRanked <- rank(1/sentRank, ties.method = tieMethod)
     topCentral <- sentRank[which(sentRanksRanked <= n)]
     centralDf <- data.frame(sentenceId=names(topCentral), value=topCentral,stringsAsFactors = FALSE)