Fix e3-pypi-closure #665
Merged
Fix e3-pypi-closure #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a package (such as ruamel) contained a dot in its name, the package retrieved by e3-pypi-closure might not be the one requested (for example when the version was set in the config file). This patch is designed to prevent this.
liaiss
approved these changes
Jan 17, 2024
leocardao
added a commit
to leocardao/e3-core
that referenced
this pull request
Jan 18, 2024
This patch adds an oversight made in AdaCore#665, to normalize the package name. This allows comparison between the package name and the name of its requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a package (such as ruamel) contained a dot in its name, the package retrieved by e3-pypi-closure might not be the one requested (for example when the version was set in the config file).
This patch is designed to prevent this.