Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Allow seed and meta geography to be the same #139

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

jamiecook
Copy link
Contributor

Fixes bug where if the seed geography is the same as the meta_geography, pandas has a small panic attack and the run will fail.

…hy, pandas has a small panic attack and the run will fail.
@bstabler bstabler self-requested a review August 18, 2021 04:03
@bstabler
Copy link
Contributor

ActivitySim 1.0.2 changed the use of toolz. We'll need to update populationsim as a result. Here's the failing Travis log....

ImportError while importing test module '/home/travis/build/ActivitySim/populationsim/populationsim/tests/test_flex.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../miniconda/envs/test-environment/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
populationsim/tests/test_flex.py:7: in <module>
    from activitysim.core import pipeline
../../../miniconda/envs/test-environment/lib/python3.7/site-packages/activitysim/core/pipeline.py:17: in <module>
    from . import random
../../../miniconda/envs/test-environment/lib/python3.7/site-packages/activitysim/core/random.py:12: in <module>
    from activitysim.core.util import reindex
../../../miniconda/envs/test-environment/lib/python3.7/site-packages/activitysim/core/util.py:13: in <module>
    import cytoolz as tz
E   ModuleNotFoundError: No module named 'cytoolz'

@jamiecook
Copy link
Contributor Author

@bstabler - I believe that error (cytoolz) is actually a problem in activitysim - I've added a PR over there to add cytoolz to the dependencies so that it's installed when you pip install activitysim. But tests on Asim take a LONG time to run on travis :/

I've also changed one of the tests here to handle another change in asim multi-processing

@bstabler bstabler merged commit fd303be into ActivitySim:develop Aug 19, 2021
@jamiecook jamiecook deleted the jamiecook/setup_data_fix branch August 19, 2021 23:44
bstabler added a commit that referenced this pull request Aug 26, 2021
* update package version number as well

* Allow non-binary incidence (#123)

* Allow non-binary incidence

* style

* update tests to pass

* add some progress indication

* tidy up validation script, use histogram for a histogram

* fix render and some typos

* increment version

* deprecate py2.7

* Multiprocess (#130)

* [Bugfix] Allow seed and meta geography to be the same (#139)

* Fixes bug where if the seed geography is the same as the meta_geography, pandas has a small panic attack and the run will fail.

* add cytoolz to the "requirements"

* fix another activitysim change

* Absolute bounds (#136)


* adding upper/lower bounds to weighting use case

* #137, #134, #133, #131

Co-authored-by: Jamie Cook <[email protected]>
Co-authored-by: Blake Rosenthal <[email protected]>
Co-authored-by: Ben Stabler <[email protected]>
Co-authored-by: Leah Flake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants