protect_columns
for all simulations (choosers, alts, simple simulate, interaction simulate, etc)
#871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following fixes:
protect_columns
to all core simulate functions.protect_columns
is a setting undercompute_settings
that can be used to protect specific columns from being dropped. But it was not fully implemented for all core simulate functions.activitysim/activitysim/core/interaction_sample.py
Line 268 in 1cb48c7
tdd
since it’s a generic variable, but less so fororigin_destination
since it’s a variable only relevant to the SANDAG xborder model. Furthermore, this crashes the ARC trip scheduling choice model. This PR moves the non-generic columns from source code to implementation-specific settings.comupte_settings
in trip_scheduling_choice.pyprotect_columns
in parking_location_choice.py