Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure Updates #812

Merged
merged 9 commits into from
Feb 28, 2024
Merged

Infrastructure Updates #812

merged 9 commits into from
Feb 28, 2024

Conversation

jpn--
Copy link
Member

@jpn-- jpn-- commented Feb 22, 2024

This PR updates some of the packaging infrastructure.

  • setup.cfg and setup.py are completely removed in favor of moving all setup into the pyproject.toml file, consistent with latest Python packaging practices.
  • The minimum Python version is pushed to 3.10 (primarily to allow type annotations in X | Y format, for ease of use with Pydantic).
  • The sparse package is added as a required dependency. This package is required for 2-zone models, and adds very little overhead to the install even for 1-zone models; it is easier to install it all the time rather than rely on users to know if it would be needed or not.

@jpn-- jpn-- requested review from i-am-sijia and dhensle February 22, 2024 18:54
@i-am-sijia
Copy link
Contributor

Change the following to destination_dir: ${{ github.ref_name }} ?

destination_dir: develop

Copy link
Contributor

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the installation on my windows laptop, it worked fine and ran the example mtc model. I had one question in my other comment.

@jpn--
Copy link
Member Author

jpn-- commented Feb 28, 2024

Change the following to destination_dir: ${{ github.ref_name }} ?

destination_dir: develop

I'm leaving this as is -- every time we have a PR against main, if it passes the foundational tests then we build and push the documentation to the "develop" subdirectory where our in-development docs live. There are other actions that push docs for specific releases etc.

@jpn-- jpn-- merged commit 2f9afa0 into ActivitySim:main Feb 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants