-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure Updates #812
Conversation
Change the following to activitysim/.github/workflows/core_tests.yml Line 564 in 5e6795e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the installation on my windows laptop, it worked fine and ran the example mtc model. I had one question in my other comment.
I'm leaving this as is -- every time we have a PR against |
This PR updates some of the packaging infrastructure.
setup.cfg
andsetup.py
are completely removed in favor of moving all setup into thepyproject.toml
file, consistent with latest Python packaging practices.X | Y
format, for ease of use with Pydantic).sparse
package is added as a required dependency. This package is required for 2-zone models, and adds very little overhead to the install even for 1-zone models; it is easier to install it all the time rather than rely on users to know if it would be needed or not.