Fix min inbound departure times #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mxndrwgrdnr, thanks for the PR. The master branch is our current release branch and is only pushed to by Travis once develop passes the tests. In addition, since this PR has some revisions already in the RSGInc fork develop branch, I think it is best to submit this PR to the RSGInc fork develop branch. I'm going to close this PR and then we can follow-up on the new PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to two modules to fix the issue in which the first inbound trip of a given tour is scheduled to depart prior to the last outbound trip of the tour:
earliestcolumn in trips table after outbound trips are scheduledfailed_trip_cohorts. cohort must include all trips associated with a tour that has a failed trip because of the new interdependence between inbound and outbound departure times.