Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update work/school location expressions for daysim style shadow pricing #250

Closed
bstabler opened this issue Mar 6, 2019 · 1 comment
Closed
Assignees

Comments

@bstabler
Copy link
Contributor

bstabler commented Mar 6, 2019

It's not needed for the verification task since verification focuses on the TM1 implementation (i.e. the ctramp approach to shadow pricing), but the daysim approach needs a couple small fixes.

  • the existing asim implementation calculates the shadow price and then multiplies it by the size term, thereby creating an adjusted size term. This is how TM1 - ctramp - does it.
  • the daysim approach calculates the shadow price and adds it to the utility as a separate term with a coefficient of 1.
  • the ctramp approach is working fine.
  • for the daysim approach, after calculating the shadow price, we need to expose it in the expression file. The daysim approach size term never changes. The separate shadow price variable changes with each iteration.

We'll plan to fix this soon.

bstabler added a commit that referenced this issue Mar 11, 2019
…daysim predicted / model misunderstanding, 3 - fix distance 0 to 1 skim expression error, 4 - set smarter defaults #250
@bstabler
Copy link
Contributor Author

this issue has migrated to #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants