Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in cleaning mock releases #135

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

wojciech-piotrowiak
Copy link
Contributor

@wojciech-piotrowiak wojciech-piotrowiak commented Nov 8, 2023

This change gives an option to remove tags and releases separately which is crucial because there is no API to remove git tags and API for release removal will not remove a tag when release does not exist

@wojciech-piotrowiak wojciech-piotrowiak changed the title workflow logs Improvement in cleaning mock releases Nov 8, 2023
@wojciech-piotrowiak wojciech-piotrowiak self-assigned this Nov 8, 2023
@wojciech-piotrowiak wojciech-piotrowiak marked this pull request as ready for review November 8, 2023 19:46
Copy link
Contributor

@atchertchian atchertchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor suggestions, otherwise LGTM 👍 , but please reference a jira issue

.github/actions/remove-mock-release-and-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/remove-mock-release-and-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/remove-mock-release-and-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/remove-mock-release-and-tag/action.yml Outdated Show resolved Hide resolved
.github/actions/remove-mock-release-and-tag/action.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@atchertchian atchertchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants