fix: double click event handling (in DOM environments) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's needed for https://github.com/cheminfo/openchemlib-js project DOM `pointerdown` and `pointerup` do not contain number of click in `detail` like `click` events. So I tweak `GenericEditorArea.eventHappened` to call `handleDoubleClick` on `GenericMouseEvent.MOUSE_CLICKED` Refs: cheminfo/openchemlib-js#232
|
@thsa Can you please review and accept the PR. We need this change in context of the OCL-JS Vaadin project. Many thanks... |
tpoisseau
added a commit
to cheminfo/openchemlib-js
that referenced
this pull request
Oct 14, 2024
add comment to not forget `event.detail` on `pointerup` / `pointerdown` do not have clickCount information Refs: Actelion/openchemlib#114 Closes: #225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed for https://github.com/cheminfo/openchemlib-js project
DOM
pointerdownandpointerupdo not contain number of click indetaillikeclickevents.So I tweak
GenericEditorArea.eventHappenedto callhandleDoubleClickonGenericMouseEvent.MOUSE_CLICKEDRefs: cheminfo/openchemlib-js#232