Refactor string literal escaping #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmisar
requested changes
Nov 4, 2020
There was a problem hiding this comment.
I think duplicated test are not necessary, it's just change of format, so I believe that 4 people's 👀 would catch the mistake if any.
If you want to keep old tests, feel free, no harm done of course, but please add a comment explaining why are there duplicated tests - could be pretty confusing in the future 😉
|
Why did you change only some of the tests? I thought that the we want to get rid of all the escaping hell. And I agree with janmisar, it's only a matter of the format and I would prefer to have just the latter |
LukasHromadnik
approved these changes
Nov 6, 2020
fortmarek
approved these changes
Nov 6, 2020
janmisar
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors internal escaping sequences so the code is bit more readable.
We should probably discuss if the "added" tests should be present or not, I didn't want to change older tests so we can be sure we do not create any regression, but still wanted to test the new "syntax" as well. I think more tests even if they test the same thing do not hurt.
Checklist