fix/Support of non-corresponding instruction and context names #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikrk
force-pushed
the
fix/non-corresponding-ix-and-ctx-names
branch
from
c8bfc37
to
74c534c
Compare
lukacan
requested changes
Feb 28, 2024
| } else { | ||
| return Err(format!("The Context struct {} was not found", ctx_ident)); | ||
| } | ||
| unique_ctxs.insert(ctx.clone(), ix_name); |
There was a problem hiding this comment.
What about, instead of storing ix_name, storing the already derived Snapshot name? I find it more intuitive to have pairs like (Context, SnapshotName).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a problem during the fuzz test generation in case the instruction and its corresponding context have different names, such as:
The correct context name was not taken into account and the fuzz test broke.
Now also the situation when one context struct is reused by multiple instructions is handled properly using a type alias. For example having another instruction re-using the context
Withdrawabove:will generate a type alias and the deserialization will be reused: