Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WASM #4

Closed
wants to merge 74 commits into from
Closed

Fix WASM #4

wants to merge 74 commits into from

Conversation

Weibye
Copy link

@Weibye Weibye commented Aug 19, 2022

We have broken wasm in quite a few places, this is an attempt to fix that.

Weibye added 30 commits August 9, 2022 23:46
@Weibye @Aceeri
Replacing Window_id with Entity
db808d6
@Weibye @Aceeri
Adding WindowCommandsExtensions for Commands
f48159c
@Weibye @Aceeri
Exploding Window into multiple coponents
3c92260
@Weibye @Aceeri
Adding WindowCommands to replace methods previously existing on `Wi…
106982b 
…ndow`
@Weibye @Aceeri
Adding new ExitCondition
4d8eade
@Weibye @Aceeri
Updating bevy_window to follow new pattern more
c841aa3
@Weibye @Aceeri
Split change_window system into multiple system that handle `Window…
9bb337a 
…Command`s
@Weibye @Aceeri
Start reworking winit_runner()
88fb27f
@Weibye @Aceeri
Add initial sketch of example
bf8bca7
@Weibye @Aceeri
Adding notes
03dbaea
@Weibye @Aceeri
Fully implement spawning of created window
a221ae0
@Weibye @Aceeri
Start updating bevy_render to new patterns
5614fab
@Weibye @Aceeri
More cleanup of winit main loop
fc6c026
@Weibye @Aceeri
minor fix
cbfeade
@Weibye @Aceeri
And more tweaks
fae2685
@Weibye @Aceeri
continuing refactor of winit-loop
cbadfa6
@Weibye @Aceeri
Finish setting up components for new windows
da767cc
@Weibye @Aceeri
cleanup
6854814
@Weibye @Aceeri
Start attempting to get rendering to compile again
558420a
@Weibye @Aceeri
Updating bevy_text
ddb0672
@Weibye @Aceeri
Fixing up bevy_ui
54f98ec
@Weibye @Aceeri
Cleanup
8e37a53
@Weibye @Aceeri
Fixing up bevy_ui
7724f01
@Weibye @Aceeri
fixing examples
5be87aa
@Weibye @Aceeri
Fixing up more examples
c9e74cd
@Weibye @Aceeri
Every finally compiles!
3ed97cc
@Weibye @Aceeri
Fixing runtime bugs
124cb57
@Weibye @Aceeri
Wrangling with timing issues in render
7f610ec
@Weibye @Aceeri
Window setup operations need to happen during build-time
0711d70
@Weibye @Aceeri
Further attempts at spawning components in build-time
e4875f7
Aceeri and others added 18 commits August 10, 2022 09:17
@Aceeri
Use derive instead of explicit impl for WindowFocus
79713e8
@Weibye
Rename field to window
e7d2c53
@Weibye
Adding more docs
8846cfa
@Weibye
Fill inn the rest of the documentation
164c819
@Aceeri
Merge pull request #1 from Weibye/rename-fields
ffa88be 
Rename fields to `window` & add some missing documentation
@Aceeri
Clean up multiple windows example
494a6c1
@Aceeri
Explain window bundle in multiple windows
376f640
@Aceeri
Remove TODOs for helpful panics, make all of the panics more helpful
294b744
@Aceeri @Weibye
Add TODO for window independent UI
505caa6 
Co-authored-by: Andreas Weibye <[email protected]>
@Aceeri
Make extract_windodws private again
8eeb266
@Aceeri
Remove commented out unused code
ba8e19a
@Aceeri
Use removal of window component to signal closing window, some clean …
08daf4b 
…up/renaming
@Aceeri
Simplify primary window closed system
0f044bb
@Weibye
Format & cleanup
144618a
@Weibye
Adding back canvas scaling
5b38a6e
@Weibye
Fixing wasm functionality
1a45c1e
@Weibye
Wasm now compiles correctly
881e099
@Weibye
Add required platform-specific code
14aab4a
@Weibye Weibye marked this pull request as ready for review August 20, 2022 10:06
@Weibye Weibye mentioned this pull request Aug 20, 2022
Closed
@Weibye
Copy link
Author

Weibye commented Aug 20, 2022 •
edited
Loading

@Aceeri This should now be ready to merge, but please review :)

Changes:

  • Bevy now compiles on wasm
  • Fix runtime panics on wasm
  • Fixed canvas-scaling
    • There are some odd behaviours around canvas scaling, but not sure if that is already existing or something we have added now
  • I think this should fully address regressions from [Merged by Bors] - Fix wasm examples bevyengine/bevy#4967

Note

  • I'm observing a canvas scaling issue where the height of the window is not correctly calculated. This is present on both main and on this branch so something we can fix later.
  • After our changes, the rate of update when rescaling has lowered. On main the window rescaling updates almost fully according to the resizing of the canvas.

@Weibye Weibye mentioned this pull request Aug 20, 2022
Closed
Weibye
Weibye commented Aug 20, 2022
View reviewed changes
crates/bevy_winit/src/lib.rs
new_windows,
winit_windows,
event_channel,
);
Copy link
Author

@Weibye Weibye Aug 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this platform-specific code looks like a hot mess, I'm not completely sure how we can clean this up more?

@Aceeri Aceeri self-requested a review August 21, 2022 09:47
@Aceeri Aceeri force-pushed the windows-as-entities branch 3 times, most recently from 33e2306 to f4fe9c2 Compare November 20, 2022 22:33
@Aceeri
Copy link
Owner

Aceeri commented Nov 23, 2022

Went ahead and cherry picked the commits onto the main branch, so this is effectively merged :)

@Aceeri Aceeri closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aceeri Aceeri Awaiting requested review from Aceeri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weibye @Aceeri