Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multiple [name] replacements in AsyncAlpine.alias(). Fixes #32 #34

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Enable multiple [name] replacements in AsyncAlpine.alias(). Fixes #32 #34

merged 1 commit into from
Dec 13, 2023

Conversation

scruffymongrel
Copy link
Contributor

Replace replace() in _handleAlias() with replaceAll().

@scruffymongrel scruffymongrel changed the title Enable multiple [name] replacements in AsyncAlpine.alias() (fixes #32) Enable multiple [name] replacements in AsyncAlpine.alias() (fixes Accudio/async-alpine#32) Oct 14, 2023
@scruffymongrel scruffymongrel changed the title Enable multiple [name] replacements in AsyncAlpine.alias() (fixes Accudio/async-alpine#32) Enable multiple [name] replacements in AsyncAlpine.alias(). Fixes #32 Oct 14, 2023
@scruffymongrel scruffymongrel changed the title Enable multiple [name] replacements in AsyncAlpine.alias(). Fixes #32 Enable multiple [name] replacements in AsyncAlpine.alias(). Fixes #32 Oct 14, 2023
@scruffymongrel scruffymongrel mentioned this pull request Oct 14, 2023
Closed
@Accudio
Copy link
Owner

Accudio commented Oct 20, 2023

Great thank you! I'm leaving this open until I've had time to look into and fix #33, and include them both in the next version.

Despite the fact it would not comply with semver, I'm planning that version to be 1.1.1. This is in theory a breaking change even if it's breaking unintended functionality, but I think the likelihood of someone relying on being able to request /component-name/[name].js is super low.

@Accudio Accudio changed the base branch from main to 1.2.0 December 13, 2023 21:10
@Accudio Accudio merged commit 131a704 into Accudio:1.2.0 Dec 13, 2023
Accudio added a commit that referenced this pull request Dec 13, 2023
@Accudio @jonwhitter
@scruffymongrel @iniznet
Version 1.2.0 (#37)
8011fc0 
* feat: alias function module loading

* Enable multiple [name] replacements in AsyncAlpine.alias() (#34)

* Use IIFE format for the CDN build. Fixes #33

* Minor formatting tweaks

* Bumped version to 1.2.0

---------

Co-authored-by: Jon Whitter <[email protected]>
Co-authored-by: Andy Dennis <[email protected]>
Co-authored-by: Yusuf Fauzan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scruffymongrel @Accudio