Fixed alias with name-less components

Accudio · Oct 2, 2022 · a559ad7 · a559ad7
1 parent fda8ff8
commit a559ad7
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 6 deletions.
diff --git a/dist/async-alpine.cjs.js b/dist/async-alpine.cjs.js
@@ -70,6 +70,7 @@ var visible = (component, requirement) => {
 var visible_default = visible;
 
 // src/core/async-alpine.js
+var internalNamePrefix = "__internal_";
 var AsyncAlpine = {
   Alpine: null,
   _options: {
@@ -187,6 +188,8 @@ var AsyncAlpine = {
     });
   },
   async _download(name) {
+    if (name.startsWith(internalNamePrefix))
+      return;
     this._handleAlias(name);
     if (!this._data[name] || this._data[name].loaded)
       return;
@@ -243,7 +246,7 @@ var AsyncAlpine = {
   },
   _parseName(attribute) {
     const parsedName = (attribute || "").split(/[({]/g)[0];
-    const ourName = parsedName || "_a-" + this._index;
+    const ourName = parsedName || `${internalNamePrefix}${this._index}`;
     return ourName;
   }
 };
diff --git a/dist/async-alpine.esm.js b/dist/async-alpine.esm.js
@@ -57,6 +57,7 @@ var visible = (component, requirement) => {
 var visible_default = visible;
 
 // src/core/async-alpine.js
+var internalNamePrefix = "__internal_";
 var AsyncAlpine = {
   Alpine: null,
   _options: {
@@ -174,6 +175,8 @@ var AsyncAlpine = {
     });
   },
   async _download(name) {
+    if (name.startsWith(internalNamePrefix))
+      return;
     this._handleAlias(name);
     if (!this._data[name] || this._data[name].loaded)
       return;
@@ -230,7 +233,7 @@ var AsyncAlpine = {
   },
   _parseName(attribute) {
     const parsedName = (attribute || "").split(/[({]/g)[0];
-    const ourName = parsedName || "_a-" + this._index;
+    const ourName = parsedName || `${internalNamePrefix}${this._index}`;
     return ourName;
   }
 };

diff --git a/dist/async-alpine.script.js b/dist/async-alpine.script.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "async-alpine",
-  "version": "0.5.2",
-  "description": "Load Alpine Componenets asyncronously. Allows for code splitting and lazy loading components!",
+  "version": "0.5.3",
+  "description": "Load Alpine Componenets asynchronously. Allows for code splitting and lazy loading components!",
   "author": "Alistair Shepherd <[email protected]>",
   "license": "Apache-2.0",
   "keywords": [],

diff --git a/src/core/async-alpine.js b/src/core/async-alpine.js
@@ -1,5 +1,7 @@
 import * as strategies from './strategies/index.js';
 
+const internalNamePrefix = '__internal_';
+
 const AsyncAlpine = {
   Alpine: null,
 
@@ -200,6 +202,7 @@ const AsyncAlpine = {
    */
   // check if the component has been downloaded, if not trigger download and register with Alpine
   async _download(name) {
+    if (name.startsWith(internalNamePrefix)) return;
     this._handleAlias(name);
     if (!this._data[name] || this._data[name].loaded) return;
     const module = await this._getModule(name);
@@ -302,7 +305,7 @@ const AsyncAlpine = {
   // take x-data content to parse out name 'output("test")' becomes 'output'
   _parseName(attribute) {
     const parsedName = (attribute || '').split(/[({]/g)[0];
-    const ourName = parsedName || '_a-' + this._index;
+    const ourName = parsedName || `${internalNamePrefix}${this._index}`;
     return ourName;
   },
 };

diff --git a/tests/inline-data.html b/tests/inline-data.html
@@ -37,6 +37,7 @@
     import Alpine from 'https://cdn.skypack.dev/alpinejs';
     import AsyncAlpine from '/dist/async-alpine.esm.js';
     AsyncAlpine.init(Alpine)
+    AsyncAlpine.alias('/components/[name].js')
     AsyncAlpine.start()
     Alpine.start()
   </script>