Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pyarrow #51

Merged
merged 6 commits into from
Mar 24, 2021
Merged

add pyarrow #51

merged 6 commits into from
Mar 24, 2021

Conversation

julesbarbosa
Copy link
Contributor

@julesbarbosa julesbarbosa commented Mar 23, 2021 •
edited
Loading

@JosuaKrause
Copy link
Contributor

please add a jira ticket
try to use we move the version to init then attr should work with editable pip
see also here: https://packaging.python.org/guides/single-sourcing-package-version/ and pypa/setuptools#1724
make sure all libraries necessary for the confluence pages get installed via normal install and editable install (test in venv)

JosuaKrause
JosuaKrause reviewed Mar 24, 2021
View reviewed changes
requirements.txt Outdated
@@ -1,5 +1,6 @@
numpy>=1.17.3
pandas>=0.25.3
pyarrow==2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use relaxed version here, too pyarrow>=2.0.0

JosuaKrause
JosuaKrause reviewed Mar 24, 2021
View reviewed changes
accern_xyme/accern_xyme.py Outdated
@@ -119,7 +119,7 @@
WVD = weakref.WeakValueDictionary


__version__ = "0.2.3"
__version__ = "0.2.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

JosuaKrause
JosuaKrause reviewed Mar 24, 2021
View reviewed changes
accern_xyme/__init__.py Outdated
@@ -1,11 +1,11 @@
# pylint: disable=unused-import
__version__ = '0.2.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double quote

JosuaKrause
JosuaKrause approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@JosuaKrause JosuaKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JosuaKrause JosuaKrause merged commit 04c8b81 into master Mar 24, 2021
@JosuaKrause JosuaKrause deleted the jsb-requir branch March 24, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosuaKrause JosuaKrause JosuaKrause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julesbarbosa @JosuaKrause