Fix integration tests for sibling XCM transfer for karura-runtime #2138

syan095 · 2022-05-19T05:38:24Z

Added foreign asset extra metadata for Module-asset-registry.
The extra data can contain outgoing Multilocation for the foreign asset, and its native currency ID.
Fixed the integration tests for sibling transfer of native BNC asset

Closes #2009

runtime/karura/src/xcm_config.rs

…odule Modified integration tests to support sibling transfer of native assets. Removed other integration-tests feature related code

…test-feature * origin/master: Return default value instead of error (#2152) remove EvmChainIdMigration (#2151) 2.6.4 (#2156) Aggregated Dex Improvement (#2140) Ability to transfer debits between loans (#2053) EVM rpc return proper error if api doesn't exists at block_id (#2144) Add claimDefaultEvmAddress (#2149) Fix estimate (#2142) update bootnodes Pay fee for other account (#2029) fix stable asset token (#2131) fix cdp-engine offchain worker (#2133) 2.6.3 (#2134) update version (#2126) support aggregated DEX (#2031) Enable evm for acala (#1907) Evm account precompile (#2124) Added no-metadata-docs and full-metadata-docs to runtimes (#2123) # Conflicts: # runtime/karura/Cargo.toml

primitives/src/currency.rs

…ir functionalities. Added unit tests and modified integration tests for the new metadata's override functions.

syan095 · 2022-05-30T01:22:51Z

/bench runtime module module-asset-registry

ghost · 2022-05-30T01:22:53Z

Finished benchmark for branch: remove-integration-test-feature

Benchmark: Benchmark Runtime Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module-asset-registry --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules//src/weights.rs --template=./templates/module-weight-template.hbs

Results

warning: unused Result that must be used
--> runtime/acala/src/benchmarking/../../../mandala/src/benchmarking/asset_registry.rs:168:3
|
168 | AssetRegistry::register_foreign_asset(RawOrigin::Root.into(), Box::new(location), Box::new(asset_metadata));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_must_use)] on by default
= note: this Result may be an Err variant, which should be handled

Compiling acala-rpc v2.6.4 (/app/git/Acala/rpc)
warning: unused Result that must be used
--> runtime/mandala/src/benchmarking/asset_registry.rs:168:3
|
168 | AssetRegistry::register_foreign_asset(RawOrigin::Root.into(), Box::new(location), Box::new(asset_metadata));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_must_use)] on by default
= note: this Result may be an Err variant, which should be handled

warning: karura-runtime (lib) generated 1 warning
warning: acala-runtime (lib) generated 1 warning
Compiling acala-service v2.6.4 (/app/git/Acala/node/service)
warning: mandala-runtime (lib) generated 1 warning
Compiling acala v2.6.4 (/app/git/Acala/node)
Finished release [optimized] target(s) in 44m 33s
Running target/release/acala benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module-asset-registry '--extrinsic=*' --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules//src/weights.rs --template=./templates/module-weight-template.hbs
Error: Input("AssetIdExisted")

syan095 · 2022-05-30T01:26:00Z

/bench runtime mandala module module-asset-registry

ghost · 2022-05-30T02:07:41Z

Finished benchmark for branch: remove-integration-test-feature

Benchmark: Benchmark Runtime Mandala Module

cargo run --profile production --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module module-asset-registry --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

Results

Compiling acala-cli v2.6.4 (/app/git/Acala/node/cli)
Compiling kusama-runtime v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling polkadot-runtime v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling rococo-runtime v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling westend-runtime v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling karura-runtime v2.6.4 (/app/git/Acala/runtime/karura)
Compiling mandala-runtime v2.6.4 (/app/git/Acala/runtime/mandala)
Compiling acala-runtime v2.6.4 (/app/git/Acala/runtime/acala)
Compiling orml-oracle-rpc v0.4.1-dev (/app/git/Acala/orml/oracle/rpc)
Compiling orml-traits v0.4.1-dev (/app/git/Acala/orml/traits)
Compiling acala-primitives v2.6.4 (/app/git/Acala/primitives)
Compiling orml-tokens v0.4.1-dev (/app/git/Acala/orml/tokens)
Compiling orml-currencies v0.4.1-dev (/app/git/Acala/orml/currencies)
Compiling orml-oracle v0.4.1-dev (/app/git/Acala/orml/oracle)
Compiling orml-rewards v0.4.1-dev (/app/git/Acala/orml/rewards)
Compiling orml-auction v0.4.1-dev (/app/git/Acala/orml/auction)
Compiling orml-payments v0.4.1-dev (/app/git/Acala/orml/payments)
Compiling orml-xcm-support v0.4.1-dev (/app/git/Acala/orml/xcm-support)
Compiling module-support v2.6.4 (/app/git/Acala/modules/support)
Compiling module-evm-rpc-runtime-api v2.6.4 (/app/git/Acala/modules/evm/rpc/runtime_api)
Compiling module-nft v2.6.4 (/app/git/Acala/modules/nft)
Compiling module-honzon-bridge v2.6.4 (/app/git/Acala/modules/honzon-bridge)
Compiling orml-tokens-rpc-runtime-api v0.4.1-dev (/app/git/Acala/orml/tokens/rpc/runtime-api)
Compiling module-collator-selection v2.6.4 (/app/git/Acala/modules/collator-selection)
Compiling orml-unknown-tokens v0.4.1-dev (/app/git/Acala/orml/unknown-tokens)
Compiling orml-xtokens v0.4.1-dev (/app/git/Acala/orml/xtokens)
Compiling module-dex v2.6.4 (/app/git/Acala/modules/dex)
Compiling module-idle-scheduler v2.6.4 (/app/git/Acala/modules/idle-scheduler)
Compiling module-loans v2.6.4 (/app/git/Acala/modules/loans)
Compiling module-transaction-payment v2.6.4 (/app/git/Acala/modules/transaction-payment)
Compiling module-evm-accounts v2.6.4 (/app/git/Acala/modules/evm-accounts)
Compiling module-cdp-treasury v2.6.4 (/app/git/Acala/modules/cdp-treasury)
Compiling module-asset-registry v2.6.4 (/app/git/Acala/modules/asset-registry)
Compiling module-currencies v2.6.4 (/app/git/Acala/modules/currencies)
Compiling module-homa v2.6.4 (/app/git/Acala/modules/homa)
Compiling module-prices v2.6.4 (/app/git/Acala/modules/prices)
Compiling module-auction-manager v2.6.4 (/app/git/Acala/modules/auction-manager)
Compiling module-xcm-interface v2.6.4 (/app/git/Acala/modules/xcm-interface)
Compiling module-incentives v2.6.4 (/app/git/Acala/modules/incentives)
Compiling module-relaychain v2.6.4 (/app/git/Acala/modules/relaychain)
Compiling module-dex-oracle v2.6.4 (/app/git/Acala/modules/dex-oracle)
Compiling ecosystem-starport v2.6.4 (/app/git/Acala/ecosystem-modules/starport)
Compiling module-nominees-election v2.6.4 (/app/git/Acala/modules/nominees-election)
Compiling module-earning v2.6.4 (/app/git/Acala/modules/earning)
Compiling ecosystem-renvm-bridge v2.6.4 (/app/git/Acala/ecosystem-modules/ren/renvm-bridge)
Compiling ecosystem-compound-cash v2.6.4 (/app/git/Acala/ecosystem-modules/compound-cash)
Compiling orml-tokens-rpc v0.4.1-dev (/app/git/Acala/orml/tokens/rpc)
Compiling orml-bencher v0.4.1-dev (/app/git/Acala/orml/bencher)
Compiling module-aggregated-dex v2.6.4 (/app/git/Acala/modules/aggregated-dex)
Compiling module-cdp-engine v2.6.4 (/app/git/Acala/modules/cdp-engine)
Compiling module-emergency-shutdown v2.6.4 (/app/git/Acala/modules/emergency-shutdown)
Compiling module-evm v2.6.4 (/app/git/Acala/modules/evm)
Compiling module-honzon v2.6.4 (/app/git/Acala/modules/honzon)
Compiling module-evm-bridge v2.6.4 (/app/git/Acala/modules/evm-bridge)
Compiling evm-rpc v2.6.4 (/app/git/Acala/modules/evm/rpc)
Compiling polkadot-client v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling polkadot-performance-test v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling polkadot-service v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
Compiling cumulus-relay-chain-interface v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-primitives-parachain-inherent v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-client-consensus-common v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-client-network v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-client-pov-recovery v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-relay-chain-inprocess-interface v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-relay-chain-rpc-interface v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-pallet-parachain-system v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-client-consensus-aura v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-client-consensus-relay-chain v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling cumulus-client-collator v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling runtime-common v2.6.4 (/app/git/Acala/runtime/common)
Compiling cumulus-client-service v0.1.0 (https://github.com/paritytech//cumulus?rev=7ffdccab93bbf011f00f61b12ff2e487ebe6294c#7ffdccab)
Compiling acala-rpc v2.6.4 (/app/git/Acala/rpc)
warning: unused Result that must be used
--> runtime/acala/src/benchmarking/../../../mandala/src/benchmarking/asset_registry.rs:168:3
|
168 | AssetRegistry::register_foreign_asset(RawOrigin::Root.into(), Box::new(location), Box::new(asset_metadata));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_must_use)] on by default
= note: this Result may be an Err variant, which should be handled

warning: unused Result that must be used
--> runtime/karura/src/benchmarking/../../../mandala/src/benchmarking/asset_registry.rs:168:3
|
168 | AssetRegistry::register_foreign_asset(RawOrigin::Root.into(), Box::new(location), Box::new(asset_metadata));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_must_use)] on by default
= note: this Result may be an Err variant, which should be handled

warning: unused Result that must be used
--> runtime/mandala/src/benchmarking/asset_registry.rs:168:3
|
168 | AssetRegistry::register_foreign_asset(RawOrigin::Root.into(), Box::new(location), Box::new(asset_metadata));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_must_use)] on by default
= note: this Result may be an Err variant, which should be handled

warning: acala-runtime (lib) generated 1 warning
Compiling polkadot-cli v0.9.22 (https://github.com/paritytech//polkadot?rev=17c7b9594aedbfc644d7e6e26f7bd244e68ccf4d#17c7b959)
warning: karura-runtime (lib) generated 1 warning
Compiling acala-service v2.6.4 (/app/git/Acala/node/service)
warning: mandala-runtime (lib) generated 1 warning
Compiling acala v2.6.4 (/app/git/Acala/node)
Finished production [optimized] target(s) in 57m 40s
Running target/production/acala benchmark pallet --chain=dev --steps=50 --repeat=20 --pallet=module module-asset-registry '--extrinsic=*' --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/
error: Found argument 'module-asset-registry' which wasn't expected, or isn't valid in this context

USAGE:
acala benchmark pallet [OPTIONS]

For more information try --help

…test-feature

Improved XCM integration test setups Rewrote and improved the sibling chain BNC token transfer

runtime/integration-tests/src/relaychain/kusama_cross_chain_transfer.rs

…t 2001 chain.

Removed the integration-tests feature from karura-runtime

b4adbe8

syan095 requested a review from xlc May 19, 2022 05:38

zqhxuyuan reviewed May 19, 2022

View reviewed changes

runtime/karura/src/xcm_config.rs Outdated Show resolved Hide resolved

Roy Yang added 2 commits May 26, 2022 10:58

Added a extra metadata storage for foreign assets in Asset Registry m…

dedd0aa

…odule Modified integration tests to support sibling transfer of native assets. Removed other integration-tests feature related code

syan095 changed the title ~~Removed the integration-tests feature from karura-runtime~~ Fix integration tests for sibling XCM transfer for karura-runtime May 25, 2022

syan095 requested a review from zqhxuyuan May 25, 2022 23:59

syan095 marked this pull request as draft May 26, 2022 01:34

zqhxuyuan reviewed May 26, 2022

View reviewed changes

primitives/src/currency.rs Outdated Show resolved Hide resolved

Renamed the fields in ForeignAssetExtraMetadata to better reflect the…

93c5e80

…ir functionalities. Added unit tests and modified integration tests for the new metadata's override functions.

syan095 requested a review from zqhxuyuan May 27, 2022 07:30

syan095 and others added 2 commits May 27, 2022 20:54

Merge branch 'master' into remove-integration-test-feature

9ce1ac5

Fixed build issue from merge

4cf11da

syan095 marked this pull request as ready for review May 29, 2022 22:05

Merge branch 'master' into remove-integration-test-feature

124e17b

Acala Benchmarking Bot and others added 4 commits May 30, 2022 02:07

Merge remote-tracking branch 'origin/master' into remove-integration-…

6f4aee7

…test-feature

Removed the ForeignAssetExtraMetadata

266b930

Improved XCM integration test setups Rewrote and improved the sibling chain BNC token transfer

no message

d420fdd

Reverted more unneeded changes

fb73ef2

shaunxw reviewed Jun 1, 2022

View reviewed changes

runtime/integration-tests/src/relaychain/kusama_cross_chain_transfer.rs Outdated Show resolved Hide resolved

runtime/integration-tests/src/relaychain/kusama_cross_chain_transfer.rs Outdated Show resolved Hide resolved

Addressed some PR comments

b19d12e

zqhxuyuan reviewed Jun 2, 2022

View reviewed changes

runtime/integration-tests/src/relaychain/kusama_cross_chain_transfer.rs Show resolved Hide resolved

Roy Yang added 3 commits June 3, 2022 12:36

Added one more integration test that tests sending BNC to mock bifros…

9b2a00a

…t 2001 chain.

Minor improvement

b0f8d65

Merged from Master branch.

08ac4b1

zqhxuyuan approved these changes Jun 4, 2022

View reviewed changes

xlc merged commit 3c25a51 into master Jun 6, 2022

xlc deleted the remove-integration-test-feature branch June 6, 2022 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix integration tests for sibling XCM transfer for karura-runtime #2138

Fix integration tests for sibling XCM transfer for karura-runtime #2138

syan095 commented May 19, 2022 •

edited

Loading

syan095 commented May 30, 2022

ghost commented May 30, 2022 •

edited by ghost

Loading

syan095 commented May 30, 2022

ghost commented May 30, 2022 •

edited by ghost

Loading

Fix integration tests for sibling XCM transfer for karura-runtime #2138

Fix integration tests for sibling XCM transfer for karura-runtime #2138

Conversation

syan095 commented May 19, 2022 • edited Loading

syan095 commented May 30, 2022

ghost commented May 30, 2022 • edited by ghost Loading

syan095 commented May 30, 2022

ghost commented May 30, 2022 • edited by ghost Loading

syan095 commented May 19, 2022 •

edited

Loading

ghost commented May 30, 2022 •

edited by ghost

Loading

ghost commented May 30, 2022 •

edited by ghost

Loading