Fix race condition in FileSystemPackageRepository
directory creation, modernize usage of os.makedirs
#1913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original impetus for this PR was to fix a race condition in
FileSystemPackageRepository.pre_variant_install
if multiple processes attempted to create a family directory in a narrow timing window.From there, I decided to also go through and "modernize" any usage of
os.makedirs
to leverage the newexist_ok
kwarg added in Python 3.2.The PR is split up into 3 commits, in case you'd prefer to only integrate a subset:
rez.utils.filesystem.safe_makedirs
with directos.makedirs
calls.os.makedirs
to useexist_ok=True
where it seems appropriate.