Fix rez.system is_production_rez_install to handle forward slash paths under windows. #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalfratczak Can you fix the DCO please? You can follow the instructions at https://github.com/AcademySoftwareFoundation/rez/pull/1899/checks?check_run_id=36186947320. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 126 126
Lines 17217 17218 +1
Branches 3017 3017
=======================================
+ Hits 10207 10208 +1
Misses 6325 6325
Partials 685 685 ☔ View full report in Codecov by Sentry. |
…lash paths under windows.
This allows to import rez module from paths with forward slashes. The following code printed "False" before the fix:
import sys
sys.path.append('C:/rez_test/Lib/site-packages')
from rez.system import system
print( 'is_production_rez_install', system.is_production_rez_install )
Signed-off-by: Michal Fratczak <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Michal Fratczak <[email protected]>
|
@JeanChristopheMorinPerso DCO fixed. |
JeanChristopheMorinPerso
approved these changes
Jan 26, 2025
JeanChristopheMorinPerso
merged commit 233b82c
into
AcademySoftwareFoundation:main
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to import rez module from paths with forward slashes. The following code printed "False" before the fix: