Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #728 - missing 'throw' in deepscanline error handling #730

Merged
merged 2 commits into from
May 20, 2020
Merged

fix #728 - missing 'throw' in deepscanline error handling #730

merged 2 commits into from
May 20, 2020

Conversation

peterhillman
Copy link
Contributor

Signed-off-by: Peter Hillman [email protected]

lgritz
lgritz approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some day, it would be good to change all of these raw new/delete to std::unique_ptr and the like.

@cary-ilm cary-ilm merged commit 3d03979 into AcademySoftwareFoundation:master May 20, 2020
@cary-ilm cary-ilm mentioned this pull request May 20, 2020
Closed
@arnow117
Copy link

Thanks for effective response! BTW, could we assign a new CVE number for this issue, for we just find it with our new fuzz framework AntFuzz

@peterhillman peterhillman deleted the issue728_missingthrow branch May 25, 2020 21:17
@cary-ilm cary-ilm added this to the v2.5.2 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
v2.5.2
Projects
None yet
Milestone
v2.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@peterhillman @arnow117 @lgritz @cary-ilm