Fix cmake install failing when install dir contains spaces, fix symlinks for shared libraries on DLL platforms #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…nks for shared libraries on DLL platforms Signed-off-by: Simon Boorer <[email protected]>
cary-ilm
added
the
Needs Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #646 when building the INSTALL project in Visual Studios 2017 by adding quotes to the install directory.
After fixing this I noticed the symlinks for the shared libraries were in the wrong directory, this is because for DLL platforms the DLL part of a shared libary is treated as a RUNTIME target instead of a LIBRARY target.
This is described in the cmake documentation here:
https://cmake.org/cmake/help/v3.0/command/install.html
After these changes building the INSTALL project worked as expected and no further quotes were needed.