More SonarCloud "bug" fixes in Imath #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christina Tempelaar-Lietz <[email protected]>
cary-ilm
reviewed
Oct 9, 2019
IlmBase/Imath/ImathEuler.h
Outdated
| // Destructor | ||
| //------------- | ||
|
|
||
| ~Euler(); |
There was a problem hiding this comment.
We should be able to declare this as ~Euler() = default; and not have to provide the definition below. That should force it to be the empty function - same behavior but fewer lines of code, and the intention is a bit clearer. Same with the other classes below.
There was a problem hiding this comment.
Sounds good, I will change that everywhere!
There was a problem hiding this comment.
I pushed a new version, let me know if all looks good now!
…ray index operators. Signed-off-by: Christina Tempelaar-Lietz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various SonarCloud bug fixes: