Clean up small number of sonarcloud bugs / warnings

IlmBase/Half/halfFunction.h

@@ -113,9 +113,13 @@ class halfFunction
 		  T nanValue     = 0);
 
 #ifndef ILMBASE_HAVE_LARGE_STACK
-    ~halfFunction () { delete [] _lut; }    
+    ~halfFunction () { delete [] _lut; }
+    halfFunction (const halfFunction &) = delete;
+    halfFunction& operator= (const halfFunction &) = delete;
+    halfFunction (halfFunction &&) = delete;
+    halfFunction& operator= (halfFunction &&) = delete;
 #endif
-    
+
     //-----------
     // Evaluation
     //-----------

IlmBase/HalfTest/testBitPatterns.cpp

@@ -210,7 +210,7 @@ testBitPatterns()
     testBits (HALF_MIN + HALF_MIN * 0.5001f,
 	      "0 00000 0000000010",
 	      "0 01101000 00000000000000000000000");
-    testBits (HALF_MIN - HALF_MIN,
+    testBits (HALF_MIN - HALF_MIN, // NOSONAR - suppress SonarCloud bug report.
 	      "0 00000 0000000000",
 	      "0 00000000 00000000000000000000000");
     testBits (HALF_MIN - HALF_MIN * 0.5f,
@@ -381,7 +381,7 @@ testBitPatterns()
     testBits (-(HALF_MIN + HALF_MIN * 0.5001f),
 	      "1 00000 0000000010",
 	      "1 01101000 00000000000000000000000");
-    testBits (-(HALF_MIN - HALF_MIN),
+    testBits (-(HALF_MIN - HALF_MIN), // NOSONAR - suppress SonarCloud bug report.
 	      "X 00000 0000000000",
 	      "X 00000000 00000000000000000000000");
     testBits (-(HALF_MIN - HALF_MIN * 0.5f),

IlmBase/IexMath/IexMathFloatExc.h

@@ -106,6 +106,10 @@ class MathExcOn
 
     IEXMATH_EXPORT MathExcOn (int when);
     IEXMATH_EXPORT ~MathExcOn ();
+    MathExcOn (const MathExcOn&) = delete;
+    MathExcOn& operator= (const MathExcOn&) = delete;
+    MathExcOn (MathExcOn&&) = delete;
+    MathExcOn& operator= (MathExcOn&&) = delete;
 
     // It is possible for functions to set the exception registers
     // yet not trigger a SIGFPE.  Specifically, the implementation

IlmBase/IlmThread/IlmThreadMutex.h

@@ -150,7 +150,11 @@ class ILMTHREAD_EXPORT Lock
         if (_locked)
             _mutex.unlock();
     }
-
+    Lock (const Lock&) = delete;
+    Lock &operator= (const Lock&) = delete;
+    Lock (Lock&&) = delete;
+    Lock& operator= (Lock&&) = delete;
+
     void acquire ()
     {
         _mutex.lock();

IlmBase/IlmThread/IlmThreadPool.cpp

@@ -89,6 +89,8 @@ struct ThreadPool::Data
 
      Data ();
     ~Data();
+    Data (const Data&) = delete;
+    Data &operator= (const Data&)  = delete;
 
     struct SafeProvider
     {
@@ -653,11 +655,12 @@ ThreadPool::Data::setProvider (ThreadPoolProvider *p)
     }
 #else
     ThreadPoolProvider *old = provider.load( std::memory_order_relaxed );
+    // work around older gcc bug just in case
     do
     {
         if ( ! provider.compare_exchange_weak( old, p, std::memory_order_release, std::memory_order_relaxed ) )
             continue;
-    } while ( false );
+    } while (false); // NOSONAR - suppress SonarCloud bug report.
 
     // wait for any other users to finish prior to deleting, given
     // that these are just mostly to query the thread count or push a

IlmBase/IlmThread/IlmThreadPool.h

@@ -136,7 +136,10 @@ class ILMTHREAD_EXPORT ThreadPool
     //-----------------------------------------------------------
 
     virtual ~ThreadPool ();
-
+    ThreadPool (const ThreadPool&) = delete;
+    ThreadPool& operator= (const ThreadPool&) = delete;
+    ThreadPool (ThreadPool&&) = delete;
+    ThreadPool& operator= (ThreadPool&&) = delete;
 
     //--------------------------------------------------------
     // Query and set the number of worker threads in the pool.
@@ -193,6 +196,10 @@ class ILMTHREAD_EXPORT Task
 
     Task (TaskGroup* g);
     virtual ~Task ();
+    Task (const Task&) = delete;
+    Task &operator= (const Task&) = delete;
+    Task (Task&&) = delete;
+    Task& operator= (Task&&) = delete;
 
     virtual void	execute () = 0;
     TaskGroup *		group();

IlmBase/Imath/ImathColor.h

@@ -62,7 +62,7 @@ class Color3: public Vec3 <T>
     Color3 ();			// no initialization
     explicit Color3 (T a);	// (a a a)
     Color3 (T a, T b, T c);	// (a b c)
-
+    ~Color3 () = default;
 
     //---------------------------------
     // Copy constructors and assignment
@@ -139,7 +139,7 @@ template <class T> class Color4
     Color4 ();			    	// no initialization
     explicit Color4 (T a);		// (a a a a)
     Color4 (T a, T b, T c, T d);	// (a b c d)
-
+    ~Color4 () = default;
 
     //---------------------------------
     // Copy constructors and assignment

IlmBase/ImathTest/testColor.cpp

@@ -67,7 +67,8 @@ testColor ()
     assert ( in3 == out3 );
 
     IMATH_INTERNAL_NAMESPACE::C4c	    	testConstructor1;
-    IMATH_INTERNAL_NAMESPACE::C4c	    	testConstructor2( testConstructor1 );
+    IMATH_INTERNAL_NAMESPACE::C4c	    	testConstructor1i ( 0.f );
+    IMATH_INTERNAL_NAMESPACE::C4c	    	testConstructor2( testConstructor1i );
 
     testConstructor1 = testConstructor2; // use these so the compiler doesn't emit a warning