Clean up setting of OpenEXR version #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set the version via the project() statement in top-level CMakeLists.txt, so all version-related settings are close together in an obvious place. Deprecate config/version.cmake and move logic to top level * Set OPENEXR_VERSION_EXTRA to "dev" for the master branch * Simplfy logic for SOVERSION.SOAGE.SOREVISION (no more SOCURRENT) Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
May 7, 2021
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
May 13, 2021
* Set the version via the project() statement in top-level CMakeLists.txt, so all version-related settings are close together in an obvious place. Deprecate config/version.cmake and move logic to top level * Set OPENEXR_VERSION_EXTRA to "dev" for the master branch * Simplfy logic for SOVERSION.SOAGE.SOREVISION (no more SOCURRENT) Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
May 16, 2021
…mySoftwareFoundation#1008 PR AcademySoftwareFoundation#1008 accidentally deleted the lines that set OPENEXR_INSTALL in the process of merging cmake/OpenEXRVersion.cmake into the top-level CMakeLists.txt. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
May 16, 2021
…#1022) PR #1008 accidentally deleted the lines that set OPENEXR_INSTALL in the process of merging cmake/OpenEXRVersion.cmake into the top-level CMakeLists.txt. Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
May 17, 2021
* Set the version via the project() statement in top-level CMakeLists.txt, so all version-related settings are close together in an obvious place. Deprecate config/version.cmake and move logic to top level * Set OPENEXR_VERSION_EXTRA to "dev" for the master branch * Simplfy logic for SOVERSION.SOAGE.SOREVISION (no more SOCURRENT) Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
May 17, 2021
* Set the version via the project() statement in top-level CMakeLists.txt, so all version-related settings are close together in an obvious place. Deprecate config/version.cmake and move logic to top level * Set OPENEXR_VERSION_EXTRA to "dev" for the master branch * Simplfy logic for SOVERSION.SOAGE.SOREVISION (no more SOCURRENT) Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
May 18, 2021
…#1022) PR #1008 accidentally deleted the lines that set OPENEXR_INSTALL in the process of merging cmake/OpenEXRVersion.cmake into the top-level CMakeLists.txt. Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the version via the project() statement in top-level
CMakeLists.txt, so all version-related settings are close together
in an obvious place. Deprecate config/version.cmake and move logic
to top level
Set OPENEXR_VERSION_EXTRA to "dev" for the master branch
Simplfy logic for SOVERSION.SOAGE.SOREVISION (no more SOCURRENT)
Signed-off-by: Cary Phillips [email protected]