Regression in Imath::succf() and Imath::predf().
#999
Comments
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this issue
May 7, 2021
…alues are given Courtesy Christian Aguilera <[email protected]> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes AcademySoftwareFoundation#999 (for the 2.4 line). Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this issue
May 12, 2021
…alues are given (#1013) Courtesy Christian Aguilera <[email protected]> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes #999 (for the 2.4 line). Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this issue
May 12, 2021
…alues are given (AcademySoftwareFoundation#1013) Courtesy Christian Aguilera <[email protected]> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes AcademySoftwareFoundation#999 (for the 2.4 line). Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this issue
May 16, 2021
* Fixed regression in Imath::succf() and Imath::predf() when negative values are given (#1013) Courtesy Christian Aguilera <[email protected]> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes #999 (for the 2.4 line). Signed-off-by: Cary Phillips <[email protected]> * Release notes for v2.5.6 and updates to SECURITY.md Signed-off-by: Cary Phillips <[email protected]> * Bump version for v2.5.6 Signed-off-by: Cary Phillips <[email protected]> * Change v2.5.6 release date to May 17, and clean up URL's Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0,
Imath::succf()andImath::predf()return incorrect values when negative numbers are given.For instance,
Imath::predf(-2)returns-1.9999998807907104instead of-2.000000238418579.As part of the commit above, the type of a member of a union was changed from signed to unsigned, breaking comparison against
> 0a few lines below.A PR was already created to address the regression in the 2.4 line: #998
The text was updated successfully, but these errors were encountered: