Add AnyDictionary and AnyVector support for V2d and Box2d #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Signed-off-by: Peter Targett <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
- Coverage 84.11% 81.66% -2.46%
==========================================
Files 198 176 -22
Lines 22241 12679 -9562
Branches 4687 2791 -1896
==========================================
- Hits 18709 10354 -8355
+ Misses 2610 1786 -824
+ Partials 922 539 -383
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 120 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
reinecke
merged commit 68d891a
into
AcademySoftwareFoundation:main
55 of 56 checks passed
rameshbabuvfxtd
pushed a commit
to rameshbabuvfxtd/OpenTimelineIO
that referenced
this pull request
Dec 10, 2024
…twareFoundation#1811) * Add AnyDictionary and AnyVector support for V2d and Box2d Signed-off-by: Peter Targett <[email protected]> --------- Signed-off-by: Peter Targett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1714
Summarize your change.
Add Imath V2d and Box2d types so they can be added as metadata in AnyDictionary and AnyVector containers.
Reference associated tests.
Add basic tests for V2d and Box2d to serializable object tests. Also, adapt the composable object test, to test metadata serialization.